Add tag dialogue doesn't work properly with right to left languages

[lauren.healy@…]

What steps will reproduce the problem?

1. Open add tag dialogue
2. name:ar=92 شارع 92
3. Right-side of the entered text is behind the drop-down arrows (so the last 92 is not visible)

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-01-03 21:28:24 +0100 (Tue, 03 Jan 2023)
Build-Date:2023-01-04 02:30:56
Revision:18622
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18622 en) Mac OS X 13.0
OS Build number: macOS 13.0 (22A380)
Memory Usage: 785 MB / 1820 MB (126 MB allocated, but free)
Java version: 1.8.0_361-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 1 2240×1260 (scaling 1.00×1.00) Display 2 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 2240×1260
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Desktop/josm.jnlp, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Dmacosx.jnlpx.dock.name=JOSM, -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-58bed0de.icns, -Djnlpx.jvm="<java.home>/bin/java"]
Dataset consistency test: No problems found

Plugins:
+ apache-commons (36034)
+ apache-http (35924)
+ auto_tools (81)
+ buildings_tools (36011)
+ easypresets (1623509627)
+ graphview (36011)
+ jna (36005)
+ mapwithai (v1.10.2)
+ mapwithai (v1.10.3)
+ markseen (14)
+ osm-obj-info (66)
+ rex (53)
+ turnrestrictions (36011)
+ utilsplugin2 (36011)

Tagging presets:
+ <josm.userdata>/EasyPresets.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
+ https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Kaart-Styles.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
+ https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Overlapping%20Ways.mapcss
- ${HOME}/Desktop/Name-en_test copy (1).mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Validator rules:
+ https://raw.githubusercontent.com/KaartGroup/KaartValidator/master/kaart.clingstone.validator.mapcss
+ https://raw.githubusercontent.com/KaartGroup/KaartValidator/master/kaart.indonesiaNames.validator.mapcss

Last errors/warnings:
- 43415.014 W: java.net.ConnectException: Connection refused (Connection refused)
- 43420.052 W: java.net.ConnectException: Connection refused (Connection refused)
- 43429.002 W: java.net.SocketTimeoutException: connect timed out
- 43429.002 W: java.net.SocketTimeoutException: connect timed out
- 43429.028 W: java.net.SocketTimeoutException: connect timed out
- 43429.028 W: java.net.SocketTimeoutException: connect timed out
- 43429.028 W: java.net.SocketTimeoutException: connect timed out
- 43429.029 W: Already here java.net.SocketTimeoutException: connect timed out
- 43435.061 W: java.net.SocketTimeoutException: connect timed out
- 43440.046 W: java.net.ConnectException: Connection refused (Connection refused)

[taylor.smock]

It looks like this is a bug with com.apple.laf.AquaLookAndFeel.

I would recommend switching to a different Look and Feel, such as Metal.

See wiki:Help/Preferences/Display for details on how to change the Look and Feel.

[taylor.smock]

I've reported this upstream. It looks like the Aqua LaF is not checking to see what the component orientation is.

See ​AquaComboBoxButton#paintComponent versus ​MetalComboBoxButton#paintComponent. Notably, MetalComboBoxButton checks to see what the orientation for the combobox is, unlike AquaComboBoxButton.

[stoecker]

Replying to taylor.smock:

I've reported this upstream.

Link or Ticket-ID?

[taylor.smock]

I'm waiting on upstream to get back to me with a ticket id.

[taylor.smock]

Upstream ticket: ​https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8301939

It looks like I missed a ticket that someone reported earlier, ​https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8023912 . That ticket has been open for > 8 years. On the plus side, my duplicate ticket points at the source code locations, so maybe it will be fixed in the next decade.

[gaben]

Just discovered JavaBugs.

[stoecker]

Replying to gaben:

Just discovered JavaBugs.

Probably not up-to-date anymore. Vincent stopped caring when Java continued to do everything which made our life harder.

[taylor.smock]

I know I haven't been keeping the JavaBugs page up-to-date.

I also know I'm not fixing the bugs in Java myself (thanks to their contribution agreement -- I actively avoid contributing code to projects with a CLA).

With that said, since we are distributing Java with JOSM for some users, we could just have a fork of the JDK with some fixes for stuff that affects us. But then we have to keep it up-to-date, which might be a PITA.