Add the template for animal_breeding

[Tepepaz]

What steps will reproduce the problem?

1. Searching for the preset of the animal_breeding amenity tag ​Tag:amenity=animal_breeding

What is the expected result?

Having the template for the above-mentioned tag

What happens instead?

Nothing Shows

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-10-31 17:29:20 +0100 (Mon, 31 Oct 2022)
Revision:18583
Build-Date:2022-11-01 02:30:58
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18583 en) Windows 11 64-Bit
OS Build number: Windows 10 Pro 2009 (22621)
Memory Usage: 4064 MB / 4064 MB (636 MB allocated, but free)
Java version: 17.0.5+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.25×1.25) \Display1 3840×2160 (scaling 1.50×1.50)
Maximum Screen Size: 3840×2160
Best cursor sizes: 16×16→48×48, 32×32→48×48
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=%UserProfile%\AppData\Local\Programs\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop]
Dataset consistency test: No problems found

Plugins:
+ imagery_offset_db (35978)
+ turnrestrictions (36011)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/SentieriItaliani&preset

Last errors/warnings:
- 00000.366 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.370 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00003.077 W: Unable to request certificate of https://roottest-g3.pkioverheid.nl
- 00003.338 W: Unable to request certificate of https://roottest-g3.pkioverheid.nl
- 00026.296 W: Region [TMS_BLOCK_v2] : Problem verifying disk.
- 00151.187 W: Region [WMS_BLOCK_v2] : Problem verifying disk.

[skyper]

Do you have an appropriate .svg icon (wiki:DevelopersGuide/DefaultPresets#NewIcons)? Searching for or even creating an icon is the major work.

[Hufkratzer]

draft for animal_breeding.svg icon

[Hufkratzer]

Made from ​https://freesvg.org/colt-and-a-mother-vector-illustration:

(16px)

(32px)

Alternative: ​https://commons.wikimedia.org/wiki/File:Cat-34820.svg

[skyper]

Thanks. I fear we need more contrasts and/or colors though.

[Hufkratzer]

Is there any point in trying to improve the icon? The tag is currently only used 6.7k times, and I think you only add presets for tags that are used at least 10k times.

[skyper]

Well, this number is only one of many indicators and not a rule, see DevelopersGuide/DefaultPresets. Two external presets already include the tag, see ​taginfo.

Personally, I do not have a problem adding the tag to defaultpresets.

[Hufkratzer]

Here is a new version with green grass and light blue background:

(16px)

(32px)

[skyper]

Thank you, much better now.

[Hufkratzer]

v2 tweaked a bit and saved as plain svg

[Hufkratzer]

Replying to skyper:

Well, this number is only one of many indicators and not a rule [...]

It seems so; animal_boarding and animal_shelter already got presets ([17142]) although they are used less.

[Klumbumbus]

In 18627/josm:

fix #22574 - Add amenity=animal_breeding (icon from ​https://freesvg.org/colt-and-a-mother-vector-illustration, modified by Hufkratzer; PD and CC0 licensed)

[Klumbumbus]

(I didn't really find the perfect place in the preset menu.)

[Hufkratzer]

animal_boarding in Accommodation and animal_shelter in Health are not so perfect either, you could put them in the same place as animal_breeding and add watering_place there too.

[skyper]

See #22660.

[Klumbumbus]

In 18638/josm:

fix #22660, see #22574 - Fix typo in animal_breeding list

[Klumbumbus]

Replying to Hufkratzer:

animal_boarding in Accommodation and animal_shelter in Health are not so perfect either, you could put them in the same place as animal_breeding and add watering_place there too.

I would group it this way:

Kinda "Animal" related is also: hunting stand, beekeeper, zoo, animal enclosure, dog park, horse riding center, fishing and bird hide, but I would rather keep them in their current group.

[Hufkratzer]

I like it.

[Klumbumbus]

In 18640/josm:

fix #22574 - Preset menu: Add "Animal" group in "Facilities" group and move some presets there