Modify

Opened 18 months ago

#22573 new defect

Excel-produced CSV file with doublequotes in fields not parsed as expected

Reported by: richlv Owned by: Don-vip
Priority: normal Milestone:
Component: Plugin opendata Version: tested
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Import the attached testcase
  2. Observe the created node

What is the expected result?

Node at precise coordinates.

What happens instead?

Node coordinates severely trimmed.

Please provide any additional information below. Attach a screenshot if possible.

When MSExcel saves a CSV file with doublequotes in fields, it uses a bit weird escaping method - a double-doublequote is considered escaped.

For example,
"56° 50' 43"""
is supposed to be parsed in
56° 50' 43"

This seems to confuse the opendata plugin, which only gets "56" out of the coordinate.

Attached is a simple testcase.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-10-31 17:29:20 +0100 (Mon, 31 Oct 2022)
Build-Date:2022-11-01 02:30:58
Revision:18583
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18583 en_GB) Mac OS X 10.15.7
OS Build number: Mac OS X 10.15.7 (19H2026)
Memory Usage: 3303 MB / 3641 MB (908 MB allocated, but free)
Java version: 1.8.0_351-b10, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 1127230987 1920×1080 (scaling 1.00×1.00) Display 69733382 1680×1050 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlp.tk=awt, -Djnlpx.jvm=<java.home>/bin/java, -Djnlpx.splashport=-1, -Djnlpx.home=<java.home>/bin, -Djnlpx.remove=false, -Djnlpx.offline=false, -Djnlpx.relaunch=true, -Djnlpx.session.data=/var/folders/nl/flqxqsmj5q963r7tcnfrdt3c0000gn/T/session7458868992427631019, -Djnlpx.heapsize=NULL,NULL, -Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.origFilenameArg=/Users/richlv/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-72e8e992, -Dsun.awt.warmup=true, -Djava.security.manager]
Dataset consistency test: No problems found

Plugins:
+ HouseNumberTaggingTool (35951)
+ InfoMode (35978)
+ Mapillary (2.0.1)
+ PicLayer (1.0.2)
+ apache-commons (36034)
+ apache-http (35924)
+ buildings_tools (36011)
+ dataimport (35932)
+ ejml (35924)
+ geotools (36028)
+ imagery_offset_db (35978)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ measurement (35978)
+ opendata (36025)
+ pbf (36034)
+ photo_geotagging (35933)
+ reverter (36011)
+ utilsplugin2 (36011)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

Last errors/warnings:
- 14678.225 W: Skipping line 111 because no valid coordinates have been found at columns CoordinateColumns [proj=WGS84 Geographic, xCol=8, yCol=7]
- 14678.225 W: Skipping line 112 because no valid coordinates have been found at columns CoordinateColumns [proj=WGS84 Geographic, xCol=8, yCol=7]
- 14678.225 W: Skipping line 113 because no valid coordinates have been found at columns CoordinateColumns [proj=WGS84 Geographic, xCol=8, yCol=7]
- 14678.225 W: Skipping line 114 because no valid coordinates have been found at columns CoordinateColumns [proj=WGS84 Geographic, xCol=8, yCol=7]
- 14678.226 W: Skipping line 115 because no valid coordinates have been found at columns CoordinateColumns [proj=WGS84 Geographic, xCol=8, yCol=7]
- 14678.226 W: Skipping line 116 because no valid coordinates have been found at columns CoordinateColumns [proj=WGS84 Geographic, xCol=8, yCol=7]
- 14678.226 W: Skipping line 117 because no valid coordinates have been found at columns CoordinateColumns [proj=WGS84 Geographic, xCol=8, yCol=7]
- 14678.226 W: Skipping line 118 because no valid coordinates have been found at columns CoordinateColumns [proj=WGS84 Geographic, xCol=8, yCol=7]
- 15046.917 E: Failed to locate image '[[Image(pond.png)]]'
- 15046.945 E: Failed to locate image '[[Image(oil-palm.png)]]'

Attachments (1)

ziemeļi_test.csv (1.5 KB ) - added by richlv 18 months ago.
Testcase

Download all attachments as: .zip

Change History (1)

by richlv, 18 months ago

Attachment: ziemeļi_test.csv added

Testcase

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Don-vip.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from Don-vip to the specified user.
Next status will be 'needinfo'. The owner will be changed from Don-vip to richlv.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from Don-vip to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.