Modify

Opened 17 months ago

Closed 4 months ago

Last modified 4 months ago

#22546 closed enhancement (fixed)

[patch] Warn about floating railway switches and crossings

Reported by: Famlam Owned by: team
Priority: normal Milestone: 23.12
Component: Core validator Version:
Keywords: railway switch railway_crossing Cc: gaben

Description

Crossings of two railways (railway=railway_crossing) and railway switches (railway=switch) by definition cannot exist as isolated nodes without any "underlying" (former) (rail)way that they're part of. Likely they're forgotten remains of now-deleted railways. Especially railway=switch seems pretty common to be remaining (already 130 in NL+BE+DE only); a 'floating' railway=railway_crossing is relatively rare (6 in NL+BE+DE)

Examples:

switch:
https://overpass-turbo.eu/s/1ov9 (ex: https://www.openstreetmap.org/node/1026459392, https://www.openstreetmap.org/node/1051328033 (both isolated nodes next to a real switch))

railway_crossing:
https://overpass-turbo.eu/s/1ova (ex: https://www.openstreetmap.org/node/4635993887 https://www.openstreetmap.org/node/2665878649 )

Hence I would propose to add the following to
https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/geometry.mapcss#L277

node:unconnected:in-downloaded-area[railway=switch],
node:unconnected:in-downloaded-area[railway=railway_crossing],

as part of the existing rule isolated node which must be connected to a way

Attachments (0)

Change History (10)

comment:1 by Famlam, 13 months ago

Summary: Warn about floating railway switches and crossings[patch] Warn about floating railway switches and crossings

comment:2 by gaben, 12 months ago

Cc: gaben added

comment:3 by gaben, 7 months ago

Milestone: 23.10

comment:4 by taylor.smock, 6 months ago

Milestone: 23.1023.11

Ticket retargeted after milestone deleted

comment:5 by Famlam, 5 months ago

Is there anything that I should still do here?

comment:6 by taylor.smock, 5 months ago

Milestone: 23.11

Ticket retargeted after milestone closed

comment:7 by taylor.smock, 5 months ago

Milestone: 23.12

comment:8 by taylor.smock, 4 months ago

Resolution: fixed
Status: newclosed

In 18914/josm:

Fix #22546: Warn about floating railway switches and crossing (patch by Famlam)

railway=switch and railway=crossing should always be connected to a railway;
neither can exist without a railway line as they are physical features of the
railway.

comment:9 by gaben, 4 months ago

Please consider closing the corresponding ticket on GH before it's forgotten.

comment:10 by taylor.smock, 4 months ago

Thanks for reminding me.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.