generator:method=solar -> generator:source=solar

[marc_marc]

What steps will reproduce the problem?

1. create a new objet
2. tag it with power=generator + generator:method=solar
3. run the validator

What is the expected result?

warning about that solar is a source, not a method

What happens instead?

no warning about the error in generator:method (​8000 occurrences)

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-10-18 17:20:19 +0200 (Tue, 18 Oct 2022)
Build-Date:2022-10-19 01:30:57
Revision:18579
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18579 fr) Linux CentOS Linux release 7.9.2009 (Core)
Memory Usage: 403 MB / 1717 MB (57 MB allocated, but free)
Java version: 1.8.0_345-b01, Red Hat, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1600×900 (scaling 1.00×1.00)
Maximum Screen Size: 1600×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: fr.utf8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: fr
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: GNOME-Classic:GNOME
Java package: java-1.8.0-openjdk:x86_64-1.8.0.345.b01
WebStart package: icedtea-web:x86_64-1.7.1
VM arguments: [-Dicedtea-web.bin.name=javaws.itweb, -Dicedtea-web.bin.location=/usr/bin/javaws.itweb]
Dataset consistency test: No problems found

Plugins:
+ ImproveOsm (232)
+ Mapillary (2.0.0)
+ apache-commons (36003)
+ apache-http (35924)
+ areaselector
+ austriaaddresshelper (1597341117)
+ cadastre-fr (36021)
+ conflation (0.6.9)
+ continuosDownload (105)
+ ejml (35924)
+ geotools (36028)
+ jackson (36006)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ log4j (36007)
+ opendata (36025)
+ pt_assistant (1ff2e15)
+ reverter (36011)
+ scripting
+ todo (30306)
+ utilsplugin2 (36011)
+ wikipedia (605)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
+ https://raw.github<user.name>content.com/Heiner-Sch/JOSM-preset-trees-Europe/master/JOSM-Preset_Trees.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1

Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
+ https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/FranceSpecificRules&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SourceObjectTag&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1

Last errors/warnings:
- 00018.265 W: Le greffon scripting nécessite la version Java 11. La version actuelle de Java est 8. Vous devez mettre à jour Java pour utiliser ce greffon.
- 00018.266 W: Le greffon areaselector nécessite la version Java 11. La version actuelle de Java est 8. Vous devez mettre à jour Java pour utiliser ce greffon.
- 00036.989 E: Impossible de trouver l'image "bus.png"

[Klumbumbus]

This is mainly one bad edit. See
​https://taginfo.openstreetmap.org/tags/generator%3Amethod=solar?filter=ways#chronology

7815 out of 8086 objects (97%) are on this spot:
​https://overpass-turbo.eu/?q=LyoKVGhpcyBxdWVyeSBsb29rxIZmb3Igbm9kZXMsIHdhecSGxJQgcmVsYXRpb27Ehgp3aXRoIMSwZSBnaXZlbiBrZXkvdmFsxIkgY29tYmluxKfEqW4uCkNoxI9zxLR5b3XElcSkxLbEqiBhbmQgxIR0xLJoxLRSdcS6YnV0dMWbYWJvxLghCiovClvFlnQ6anPEql1bxKhtZcW4OjI1XTsKLy_EtcSnxaTFmMSadWx0cwooCiAgxorEh8SJxIsgcGFyxaLEk3I6IMOiwoDCnCJnxLnEisSnxJQ6xoHEsMSYIj3FvMSmcsanwp3Gl8SdxJ9bxqrGrHLGrsakxrHFkWTGtCLGtsagIl0oe3tixa94fX0pxojHlcaJxotwcsWJxaLEpHPGkcaTCsW4IMWvZHnGiD7GiMejc8S8bMSHdDs&c=Ae3JL9L-1P

[taylor.smock]

I think this is covered by the Presets do not contain property value check.

@marc_marc: Please enable the Other/Informational error level by going to JOSM Preferences -> Data validator -> Show informational level.

[marc_marc]

Klumbumbus thanks, ​commented, how did you find it ? ​https://taginfo.openstreetmap.org/tags/generator%3Amethod=solar?filter=ways#map doesn't show a big heatmap

taylor.smock it's enable and give an info about unknown value but the info level give this warning for most of tags and doesn't warn that's the issue is the key, not the value. it also don't have a "fix it"

[Klumbumbus]

Replying to marc_marc:

Klumbumbus thanks, ​commented, how did you find it ?

• On ​https://taginfo.openstreetmap.org/tags/generator%3Amethod=solar?filter=ways#overview I clicked on Overpass turbo top right.
• There I zoomed to Europe and executed the query, which returned only a few ways down right.
• Zoomed to South America -> also only a few ways.
• Zoomed to USA -> returned ~8k ways
• The one spot in colorado looks the most saturated. i.e. the most circles above each other.
• Zoomed in there executeded the query again -> still ~8k ways. Done. :)

[marc_marc]

Klumbumbus thanks, good catch !

following my requestion, the contributor fix ~8k own mistakes.
there are only 271 left.