Pressing waste basket to delete last filter selected in Filter list, deletes first filter, not last filter selected

[sharcrash]

What steps will reproduce the problem?

1. selecting last filter
2. pressing waste basket (delete key does not work)

What is the expected result?

Deleting last filter in list

What happens instead?

Deletes first filter in list

Please provide any additional information below. Attach a screenshot if possible.

Selecting a random filter in the middle of the list and pressing waste basket does delete the right one

Revision:18570
Build-Date:2022-10-07 11:33:30

Identification: JOSM/1.5 (18570 en) Windows 7 64-Bit
OS Build number: Windows 7 Ultimate (7601)
Memory Usage: 1424 MB / 4092 MB (256 MB allocated, but free)
Java version: 17.0.4+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1280×1024 (scaling 1.00×1.00) \Display1 1280×1024 (scaling 1.00×1.00)
Maximum Screen Size: 1280×1024
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18570, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=C:\Program Files (x86)\JOSM\josm.exe]

Plugins:
+ ElevationProfile (35978)
+ SimplifyArea (35978)
+ alignways (36011)
+ apache-commons (36003)
+ buildings_tools (36011)
+ continuosDownload (105)
+ contourmerge (v0.1.9)
+ easypresets (1623509627)
+ ejml (35924)
+ geotools (36024)
+ jackson (36006)
+ jaxb (35952)
+ jts (36004)
+ opendata (36025)
+ photo_geotagging (35933)
+ photoadjust (36011)
+ rasterfilters (1.0.3)
+ reltoolbox (35976)
+ reverter (36011)
+ undelete (36011)
+ utilsplugin2 (36011)

Tagging presets:
+ <josm.pref>/EasyPresets.xml

Map paint styles:
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/FixmeAndNote&zip=1
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksPlus&zip=1
+ https://github.com/gmgeo/osmic-josm-style/archive/master.zip

Last errors/warnings:
- 00027.112 W: Can't use layer MNT BDAlti V1 because no supported formats were found. Layer is available in formats: image/x-bil;bits=32
- 00027.112 W: Can't use layer Modèle Numérique de Terrain issu du RGEALTI because no supported formats were found. Layer is available in formats: image/x-bil;bits=32
- 00027.113 W: Can't use layer Modèle numérique de surface because no supported formats were found. Layer is available in formats: image/x-bil;bits=32
- 00027.113 W: Can't use layer MNT SRTM3 because no supported formats were found. Layer is available in formats: image/x-bil;bits=32
- 00027.114 W: Can't use layer ISOHYPSE because no supported formats were found. Layer is available in formats: application/x-protobuf
- 00027.131 W: Can't use layer MNT BDAlti V1 because no supported formats were found. Layer is available in formats: image/x-bil;bits=32
- 00027.131 W: Can't use layer Modèle Numérique de Terrain issu du RGEALTI because no supported formats were found. Layer is available in formats: image/x-bil;bits=32
- 00027.132 W: Can't use layer Modèle numérique de surface because no supported formats were found. Layer is available in formats: image/x-bil;bits=32
- 00027.132 W: Can't use layer MNT SRTM3 because no supported formats were found. Layer is available in formats: image/x-bil;bits=32
- 00027.133 W: Can't use layer ISOHYPSE because no supported formats were found. Layer is available in formats: application/x-protobuf

[sharcrash]

Forget what i said about having selected a random filter in the middle of the list... ¬¬ Even while having selected another one than last filter, does not delete the one selected. So, I don't know...

[taylor.smock]

Closed as duplicate of #22439.
I've already fixed this.

Please update to JOSM r18571 or later (josm-latest.jar).

---

In r18571/josm:

Fix #22439: Filter deleting always deletes the first filter regardless of selection

[taylor.smock]

To clarify, thank you for the bug report -- it helps to know that something isn't working properly.

I didn't do a hotfix for the fix since (in the month that the bug was present), I only got a bug report on it last week after a hotfix release for #22183.

It looks like you are using the Windows installer -- if you want the fix for #22439, you can download the installer from ​https://github.com/JOSM/josm/releases/tag/18573 (look for JOSM-Windows-java17-18573.jar ).

[sharcrash]

OK thank you! Yeah I didn't know as the latest release is not yet announced in JOSM.

[taylor.smock]

There are two release streams for JOSM:

• josm-tested (which is what you are currently using). This is what the release announcements are for.
• josm-latest (which has whatever was the latest source at the nightly build time, which I think is 02:00 UTC every day, assuming someone applied a patch)

josm-latest is pretty stable, and is OK for daily use. josm-tested is something that hopefully has no bugs, but without people using josm-latest and reporting bugs, josm-tested gets the bugs, and then we have to do hotfixes. Which is no fun.

I would like to see more people using josm-latest so that bugs are fixed faster/noticed earlier. Around release time (3 days before/3 days after minimum, although I usually do 7 days before/after), I only do bug fixes. After 3+ days have gone by, I try to start applying patches (especially those from others). This is when most bugs get introduced. Unfortunately, it seems that almost no one is using josm-latest. Which means that some bugs might not be discovered until the next josm-tested release, and most of which won't be fixed (EDIT: in a josm-tested release) until the josm-tested release after that, unless they are sufficiently critical.

[sharcrash]

Good to know! I've subscribed for notifications of JOSM's latest releases in Github.

[taylor.smock]

Thanks. :)

I really do appreciate bug reports. I would much prefer to have several duplicate reports than none at all. We cannot fix issues of which we have no knowledge.