Warn about fire_hydrant without fire_hydrant:position

[Timonade]

Please add in trunk/resources/data/validator/combinations.mapcss?rev=18546​ line 178 this

node[emergency=fire_hydrant][!fire_hydrant:position]

Timonade

[taylor.smock]

I fail to see what adding node[emergency=fire_hydrant][fire_hydrant:position], is supposed to accomplish. You want to have the validator show a warning when emergency=fire_hydrant + fire_hydrant:position=sidewalk? Maybe you meant node[emergency=fire_hydrant][!fire_hydrant:position], instead.

Anyway, I don't think we want to add that to the default warnings. emergency=fire_hydrant is valid without fire_hydrant:position, just incomplete. If you have a specific use case, you can put it in a custom fire_hydrant.validator.mapcss file.

[Timonade]

You got it right, I just think it's better if this is displayed as an error than that the map is incomplete.

[taylor.smock]

I'm going to close this as wontfix for now.

Currently, we don't do that with any other primary feature, with a few specific exceptions where the feature is not terribly useful without an additional tag (a major highway with no name or ref, for example). We don't even prompt users to add surface, lane, maxspeed, or any other useful information to highway objects.

I would absolutely add a warning if fire_hydrant:position existed but emergency=fire_hydrant did not, since the primary tag is emergency=fire_hydrant.

If you feel like it, it would be trivial for you to write your own validator style (i.e., Incomplete Object Warnings) and add it to wiki:Rules.

meta
{
  title: "Incomplete Object Warnings";
  version: "[[revision]]_[[date]]";
  description: "Checks for incomplete data";
  author: "Timonade";
}
node[emergency=fire_hydrant][!fire_hydrant:position] {
  throwWarning: tr("{0} without {1}.", "{0.tag}", "{1.key}");
  group: tr("incomplete data");
}

[Timonade]

I don't understand how to write my own validator style

[taylor.smock]

I modified wiki:Rules/IncompleteObjectWarnings in wiki:Rules/IncompleteObjectWarnings?action=diff&version=2 , if that helps.