Modify

Opened 18 months ago

Closed 18 months ago

Last modified 18 months ago

#22401 closed enhancement (wontfix)

Warn about fire_hydrant without fire_hydrant:position

Reported by: Timonade Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: fire_hydrant Cc:

Description (last modified by skyper)

Please add in trunk/resources/data/validator/combinations.mapcss?rev=18546 line 178 this

node[emergency=fire_hydrant][!fire_hydrant:position]

Timonade

Attachments (0)

Change History (6)

comment:1 by skyper, 18 months ago

Component: CoreCore validator
Description: modified (diff)
Keywords: fire_hydrant added
Milestone: Longterm
Summary: Add a line in combinationsWarn about fire_hydrant without fire_hydrant:position
Type: defectenhancement

comment:2 by taylor.smock, 18 months ago

I fail to see what adding node[emergency=fire_hydrant][fire_hydrant:position], is supposed to accomplish. You want to have the validator show a warning when emergency=fire_hydrant + fire_hydrant:position=sidewalk? Maybe you meant node[emergency=fire_hydrant][!fire_hydrant:position], instead.

Anyway, I don't think we want to add that to the default warnings. emergency=fire_hydrant is valid without fire_hydrant:position, just incomplete. If you have a specific use case, you can put it in a custom fire_hydrant.validator.mapcss file.

EDIT: Feel free to correct me if I misunderstood you.

Last edited 18 months ago by taylor.smock (previous) (diff)

comment:3 by Timonade, 18 months ago

You got it right, I just think it's better if this is displayed as an error than that the map is incomplete.

comment:4 by taylor.smock, 18 months ago

Resolution: wontfix
Status: newclosed

I'm going to close this as wontfix for now.

Currently, we don't do that with any other primary feature, with a few specific exceptions where the feature is not terribly useful without an additional tag (a major highway with no name or ref, for example). We don't even prompt users to add surface, lane, maxspeed, or any other useful information to highway objects.

I would absolutely add a warning if fire_hydrant:position existed but emergency=fire_hydrant did not, since the primary tag is emergency=fire_hydrant.

If you feel like it, it would be trivial for you to write your own validator style (i.e., Incomplete Object Warnings) and add it to wiki:Rules.

meta
{
  title: "Incomplete Object Warnings";
  version: "[[revision]]_[[date]]";
  description: "Checks for incomplete data";
  author: "Timonade";
}
node[emergency=fire_hydrant][!fire_hydrant:position] {
  throwWarning: tr("{0} without {1}.", "{0.tag}", "{1.key}");
  group: tr("incomplete data");
}

comment:5 by Timonade, 18 months ago

I don't understand how to write my own validator style

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.