GeoJSON: when multiple nodes have the same coordinates, they are merged

[tguen]

What steps will reproduce the problem?

1. Import a .geojson file with multiple tagged nodes at the same location.

What is the expected result?

Each feature in the geojson file should be imported as a separate object

What happens instead?

Points with identical coordinates are imported as one object with merged tags

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-05-29 21:53:52 +0200 (Sun, 29 May 2022)
Revision:18463
Build-Date:2022-05-30 01:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18463 en) Linux Arch Linux
Memory Usage: 280 MB / 3936 MB (82 MB allocated, but free)
Java version: 18.0.2+0, N/A, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 2560×1440 (scaling 1.00×1.00)
Maximum Screen Size: 2560×1440
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: ANSI_X3.4-1968
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: KDE
VM arguments: [--add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, -Djosm.restart=true, -Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugins:
+ apache-commons (36003)
+ ejml (35924)
+ geotools (36015)
+ jackson (36006)
+ jaxb (35952)
+ jts (36004)
+ opendata (35910)
+ utilsplugin2 (35970)

Last errors/warnings:
- 00012.993 W: No valid coordinates have been found.

[tguen]

example geojson file

[taylor.smock]

This is a fairly easy "fix". The question is what other behavior is going to break.

src/org/openstreetmap/josm/io/GeoJSONReader.java

@@ -323 +323 @@
     }
 
     private Node createNode(final LatLon latlon) {
-        final List<Node> existingNodes = getDataSet().searchNodes(new BBox(latlon, latlon));
-        if (!existingNodes.isEmpty()) {
+        final Optional<Node> existingEmptyNode = getDataSet().searchNodes(new BBox(latlon, latlon)).stream()
+                .filter(n -> !n.hasKeys()).findFirst();
+        if (existingEmptyNode.isPresent()) {
             // reuse existing node, avoid multiple nodes on top of each other
-            return existingNodes.get(0);
+            return existingEmptyNode.get();
         }
         final Node node = new Node(latlon);
         getDataSet().addPrimitive(node);

[taylor.smock]

Closed as duplicate of #21044.

[skyper]

Probably, better reopen this ticket as #21044 already has a milestone and should remain as "fixed".

I guess for nodes without parent it will work but how about nodes with parents, especially first or last node of a way? Do we run into the problems of #19041, again?

[taylor.smock]

Fair enough.

I'd have to write tests for corner cases anyway. Like I said in comment:1, "[the] question is what other behavior is going to break."

[CjMalone]

I write .osm files to avoid the current merging behaviour, but I'd much prefer to be able to load geojsons.