[Patch] Nodes should be exclude from "construction:highway without highway and construction"

[skyper]

What steps will reproduce the problem?

1. Have a node with construction:highway=*, e.g. ​api/0.6/node/303193688/26
2. Run validator

What is the expected result?

No warning

What happens instead?

• construction:highway without highway and construction
• highway together with construction:highway and conflicting values plus no construction

Please provide any additional information below. Attach a screenshot if possible.

The validator test should exclude nodes. Same might be true for railway

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-08-29 16:59:00 +0200 (Mon, 29 Aug 2022)
Revision:18543
Build-Date:2022-08-30 01:30:57
URL:https://josm.openstreetmap.de/svn/trunk

[skyper]

patch, only using way and relation for highway and railway

[skyper]

Please find attached patch​​ only checking way and relation for highway and railway.

[taylor.smock]

I'm not certain about this -- do we have wiki documentation on this?

highway=crossing + crossing=uncontrolled + construction:crossing=traffic_signals + construction:highway=traffic_signals
maybe should be
highway=crossing + crossing=uncontrolled + construction:crossing=traffic_signals + construction=traffic_signals.

Maybe we should add the active commentators on #17607 here?

[skyper]

Unfortunately, there is only little documentation and it is either general (construction=*) or only about ways (highway=construction). Though, nodes are not excluded in the wiki.
Maybe, it is better to use the scheme for all object types. Opinions?

By the way, we should warn about construction=highway/railway/building/landuse.

Edit: Probably one reason for my interpretation of excluding nodes are the missing values in presets and data, so far.

[mkoniecz]

Maybe this warning should be raised only on construction:highway values matching way classes such as motorway or path or cycleway or tertiary?

[goodidea]

I just wanted to point out that there are also false positives for nodes with construction:highway=bus_stop. I don't think that construction=bus_stop should be added here, that would be quite redundant and superfluous. And there is nothing about this in the wiki under ​https://wiki.openstreetmap.org/wiki/Key:construction. Maybe this also affects other highway node tags (e.g. highway=platform, highway=street_lamp, ...).

Example node: ​https://www.openstreetmap.org/node/11985459357

Would be nice if this could be fixed.