Modify

Opened 3 years ago

Closed 2 years ago

#22319 closed defect (fixed)

[PATCH][GitHub Plugin] Public Transport assistant validator does not recognise stop_positions on railway=narrow_gauge

Reported by: riiga_92@… Owned by: Biswesh
Priority: normal Milestone:
Component: Plugin pt_assistant Version:
Keywords: template_report validator stop position narrow gauge Cc:

Description

What steps will reproduce the problem?

  1. Place a public_transport=stop_position on a narrow gauge railway.
  2. Run the validator

What is the expected result?

No errors or warnings.

What happens instead?

PTAssistant warns "Stop position is not part of a way".

Please provide any additional information below. Attach a screenshot if possible.

Tested by changing the railway to regular rail and re-running the validator, which gives no warnings.

Also tested as pictured in the attachment.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-05-29 21:53:52 +0200 (Sun, 29 May 2022)
Revision:18463
Build-Date:2022-05-30 01:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18463 en) Linux Manjaro Linux
Memory Usage: 2076 MB / 3984 MB (1062 MB allocated, but free)
Java version: 18.0.2+9, N/A, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: sv_SE.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_SE
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: KDE
VM arguments: [--add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, -Djosm.restart=true, -Dawt.useSystemAAFontSettings=gasp]
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (35924)
+ FastDraw (35893)
+ ImportImagePlugin
+ OpeningHoursEditor (35924)
+ PicLayer (1.0.2)
+ apache-commons (36003)
+ apache-http (35924)
+ areaselector (405)
+ austriaaddresshelper (1597341117)
+ buildings_tools (35997)
+ ejml (35924)
+ geotools (36008)
+ imagery_offset_db (35893)
+ jackson (36006)
+ jaxb (35952)
+ jna (36005)
+ jogl (1.2.3)
+ jts (36004)
+ kendzi3d-resources (0.0.2)
+ log4j (36007)
+ measurement (35976)
+ opendata (35910)
+ pt_assistant (1ff2e15)
+ reverter (35999)
+ tageditor (35893)
+ terracer (35893)
+ turnlanes-tagging (v0.0.5)
+ turnrestrictions (36009)
+ utilsplugin2 (35970)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportOneClick&zip=1
+ ${HOME}/Dokument/QuickSets.zip
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Fixme&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings_sv&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PriorityRoad&zip=1
- ${HOME}/Dokument/OSM/sidewalks-mod.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleBuildingTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&zip=1
- https://raw.githubusercontent.com/yopaseopor/indoormap/master/indoormap-style.mapcss
- https://github.com/GlassOceanos/indoor-JOSM-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksAndFootways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Postcode&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
- ${HOME}/Dokument/OSM/Styles_ParkingLanes-style.mapcss
- https://www.openrailwaymap.org/styles/standard.zip

Last errors/warnings:
- 12602.400 E: Failed to locate image 'blue-sign-with-car.svg'
- 12602.400 W: Mappaint style "standard" (Parking lanes) icon "blue-sign-with-car.svg" not found.
- 12633.007 E: Failed to locate image 'blue-sign-with-car.svg'
- 12633.007 W: Mappaint style "standard" (Parking lanes) icon "blue-sign-with-car.svg" not found.
- 13344.252 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'
- 13344.663 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'
- 13354.420 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'
- 13354.816 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'
- 13361.094 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'
- 13361.776 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'

Attachments (1)

Screenshot_20220827_201117.png (57.5 KB ) - added by riiga_92@… 3 years ago.

Download all attachments as: .zip

Change History (5)

by riiga_92@…, 3 years ago

comment:1 by skyper, 3 years ago

Keywords: validator stop position narrow gauge added

Similar to #18034.

comment:2 by riiga_92@…, 3 years ago

I've submitted a patch on GitHub which covers both. https://github.com/JOSM/pt_assistant/pull/49

comment:3 by skyper, 3 years ago

Summary: Public Transport assistant validator does not recognise stop_positions on railway=narrow_gauge[PATCH][GitHub Plugin] Public Transport assistant validator does not recognise stop_positions on railway=narrow_gauge

comment:4 by taylor.smock, 2 years ago

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Biswesh.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.