[PATCH][GitHub Plugin] False positive "Stop_position is not part of a way" for monorail stops

[Claudius]

What steps will reproduce the problem?

1. Load the monorail route relation ​4568069 (This contains stop positions tagged as public_transport=stop_position + monorail=yes on track tagged as railway=monorail)
2. Run JOSM Validator on that data

What is the expected result?

No public transport warnings to be flagged for this data

What happens instead?

"PT: Stop_position is not part of a way" error flagged for a bunch of these stop positions

Please provide any additional information below. Attach a screenshot if possible.

I assume it's caused by railway=monorail not being included in the public transport way group.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-08-11 22:00:20 +0200 (Sun, 11 Aug 2019)
Build-Date:2019-08-12 01:30:56
Revision:15296
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15296 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1903 (18362)
Memory Usage: 183 MB / 989 MB (59 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-Dsun.java2d.opengl=true]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.18)
+ OpeningHoursEditor (34977)
+ apache-commons (34908)
+ apache-http (34908)
+ buildings_tools (34982)
+ jna (34908)
+ pt_assistant (705)
+ tageditor (34977)
+ turnlanes-tagging (281)
+ utilsplugin2 (34977)
+ wikipedia (v1.1.1)

Tagging presets:
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ https://raw.githubusercontent.com/yopaseopor/indoormap/master/indoormap-style.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/AdvertisingStyle&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Bench&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Building_Levels_Labels&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/RU-SubwayEntranceLabeling&zip=1
+ https://github.com/osmlab/appledata/archive/josm_paint_inline_validation.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Cannot start IPv4 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect
- W: Cannot start IPv6 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect

[Claudius]

This actually seems to be caused by the PT Assistant validation and the fact that "monorail" is not an accepted value for the isWaySuitableForPublicTransport() function:
​https://github.com/JOSM/pt_assistant/blob/1ff2e15f3ec059ccf032612b626b731dfc29e7b7/src/main/java/org/openstreetmap/josm/plugins/pt_assistant/utils/RouteUtils.java#L252

[skyper]

Similar to #22319.

[skyper]

See ​​https://github.com/JOSM/pt_assistant/pull/49

[taylor.smock]

In ​dd262321c3393ec7597bcb5128f0874c3446880d.