Warn when highway=living_street is combined with bicycle_road=yes

[GerdP]

What steps will reproduce the problem?

1. have a way tagged highway=living_street
2. add tag bicycle_road=yes
3. run validator

What is the expected result?

Warning that these tags are mutually exclusive

What happens instead?

no warning or information

Please provide any additional information below. Attach a screenshot if possible.

Changeset discussion: ​https://www.openstreetmap.org/changeset/123342578

Revision:18513
Build-Date:2022-07-08 01:44:25

Identification: JOSM/1.5 (18513 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19044)
Memory Usage: 414 MB / 1972 MB (235 MB allocated, but free)
Java version: 17.0.3+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18513, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\HWConsole.exe]

Plugins:
+ OpeningHoursEditor (35924)
+ apache-commons (35924)
+ buildings_tools (35997)
+ contourmerge (v0.1.9)
+ ejml (35924)
+ geotools (35959)
+ imagery-xml-bounds (35976)
+ jackson (35958)
+ jaxb (35952)
+ jts (35976)
+ o5m (35893)
+ opendata (35984)
+ pbf (35978)
+ poly (35976)
+ reltoolbox (35976)
+ reverter (35999)
+ undelete (35893)
+ utilsplugin2 (36001)

Validator rules:
+ c:\josm\core\resources\data\validator\geometry.mapcss
+ c:\josm\core\resources\data\validator\unnecessary.mapcss
+ d:\java_tools\JOSM\mygeometry.mapcss

Last errors/warnings:
- 00000.602 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.604 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00001.268 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available

[GerdP]

I think it could be just another clause in the {0.tag} together with {1.key} block, but since bicyle_road is a Germany-only tag it might better be placed in the Germany specific rules?

resources/data/validator/combinations.mapcss

@@ -297 +297 @@
 *[nohousenumber?][addr:housenumber],
 *[actuator][handle][actuator !~ /(^|;)manual(;|$)/],
 *[mechanical_driver][handle][mechanical_driver !~ /(^|;)manual(;|$)/],
+way[highway=living_street][bicycle_road=yes],
 way[oneway=yes][/:backward/][!traffic_sign:backward][bicycle:backward!=use_sidepath][/^oneway:(bicycle|bus|mofa|moped|psv)$/!~/^no$/],
 way[oneway=yes][/:forward/ ][!traffic_sign:forward ][bicycle:forward!=use_sidepath ][/^oneway:(bicycle|bus|mofa|moped|psv)$/!~/^no$/],
 way[oneway=-1 ][/:backward/][!traffic_sign:backward][bicycle:backward!=use_sidepath][/^oneway:(bicycle|bus|mofa|moped|psv)$/!~/^no$/],

[Klumbumbus]

Replying to GerdP:

it might better be placed in the Germany specific rules?

Both would be fine. Since it is not really such a big problem (62 cases global) I would probably rather add it to the Germany specific rules

Overpass turbo wizard: type:way and bicycle_road=yes and highway=living_street global

[GerdP]

Do you know how many users in Germany activate those extra rules? I didn't use them before writing this ticket.

[Klumbumbus]

No.

[GerdP]

Hm, add it where you think it's best. We can move it later if needed.

[skyper]

The combination is always wrong on the globe.
How about a warning for countries where bicycle_road=* is invalid in general plus a warning for the combination in countries where it is valid? Both in JOSM core.

[GerdP]

My understanding is that bicycle_road=yes outside of Germany should produce a warning, so far it's a Germany-only tag.

[skyper]

According to the ​German wiki page bicycle_road=yes is valid in Austria.
Where it is invalid, ​Key:cyclestreet could be suggested.

[GerdP]

Ah, you are right. I only looked at the english wiki which says "This is a specific German concept".

[Klumbumbus]

Replying to GerdP:

bicycle_road=yes outside of Germany should produce a warning

-1
If users in [insert random country here] like to use this tag (probably with an own country specific definition), this is perfectly fine imho. We should not "forbid" it.

[GerdP]

No, in that case we cannot assume anything about the meaning of the tag.

[skyper]

My understanding is that bicycle_road=* is restricted to a few countries with the strict meaning as designated road for bicycles and every other transport mode (except foot) needs an additional sign. In all other countries the less stricter cyclestreet=* might be the proper tag. In Germany and probably Austria cyclestreet=* is invalid

Regarding highway=* only a few values are valid combinations, e.g. all values above unclassified plus many lower class values. In Germany only unclassified, residential, service and path are valid values.