[NEEDS RELEASE][PATCHED] conflation: JTS AssertionFailedException in org.openstreetmap.josm.plugins.conflation.MatchesComputation.generateMatches

[IanVG]

What steps will reproduce the problem?

1. Download building and address data in area through: "addr:housenumber" = * OR building=* in "Athens-Clarke County" in query wizard.
2. Import .osm file data of addresses through OpenData plugin.
3. Filter out relations using filter plugin.
4. Using search tool, find "addr:housenumber"=* in the subject layer and freeze data.
5. Select all data from imported .osm file and freeze for reference layer.
6. Generate matches using addr:housenumber.
7. Run conflation plugin.

What is the expected result?

Generate conflation matches.

What happens instead?

Run error. Plugin does not run and matches are not generated.

Please provide any additional information below. Attach a screenshot if possible.

Revision:18463
Build-Date:2022-05-30 10:23:53

Identification: JOSM/1.5 (18463 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 2009 (19044)
Memory Usage: 2168 MB / 8128 MB (1639 MB allocated, but free)
Java version: 17.0.3+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18463, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ apache-commons (35924)
+ apache-http (35924)
+ conflation (0.6.9)
+ ejml (35924)
+ geotools (35959)
+ jackson (35958)
+ jaxb (35952)
+ jna (35924)
+ jts (35924)
+ opendata (35910)
+ utilsplugin2 (35970)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings_en&zip=1
- <josm.pref>\plugins\indoorhelper\resources\sit.mapcss

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/IndoorRules&zip=1

Last errors/warnings:
- 00000.194 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.195 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00002.076 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 00074.819 E: Handled by bug report queue: org.locationtech.jts.util.AssertionFailedException: Score = 1.999922183827763



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (32) of main
org.locationtech.jts.util.AssertionFailedException: Score = 1.999922183827763
	at org.locationtech.jts.util.Assert.isTrue(Assert.java:46)
	at com.vividsolutions.jcs.conflate.polygonmatch.Matches.add(Matches.java:166)
	at com.vividsolutions.jcs.conflate.polygonmatch.WeightedMatcher.toMatches(WeightedMatcher.java:98)
	at com.vividsolutions.jcs.conflate.polygonmatch.WeightedMatcher.match(WeightedMatcher.java:91)
	at com.vividsolutions.jcs.conflate.polygonmatch.ChainMatcher.match(ChainMatcher.java:74)
	at com.vividsolutions.jcs.conflate.polygonmatch.BasicFCMatchFinder.match(BasicFCMatchFinder.java:73)
	at com.vividsolutions.jcs.conflate.polygonmatch.DisambiguatingFCMatchFinder.match(DisambiguatingFCMatchFinder.java:30)
	at org.openstreetmap.josm.plugins.conflation.MatchesComputation.generateMatches(MatchesComputation.java:80)
	at org.openstreetmap.josm.plugins.conflation.ConflationToggleDialog$2.realRun(ConflationToggleDialog.java:1151)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:94)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:142)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)

[taylor.smock]

This should have been fixed (see #21788).

It looks like we never released an updated version of the plugin. See ​https://github.com/JOSM/conflation/compare/v0.6.9...master, specifically, this was fixed with ​194bccf4a95d4cd61c36c68d4d56369af00de68b.

[IanVG]

Tyndare, thanks for the quick response. So I found the root cause of the problem. If there is a duplicate node (at least two nodes in the same exact position) with at least one tag that matches the tag query of the conflation plugin, then the conflation plugin gets confused and cannot run.

Regarding the most up-to-date version of the plugin, is there a way I can install it? I have a couple hundred addresses that are currently stacked on top of each other, and I can't filter them out, so I can't run the plugin atm anymore.

Edit: The score of 1.999... was received because of the two nodes that it encountered in the same spot. Now, why it wasn't exactly 2.00? I do not understand.

[taylor.smock]

I'm not Tyndare.

I did create the fix in #21788, I just don't have the ability to do a release on GitHub.

I can upload a version tomorrow to this ticket (AKA when I've got access to my computer with the dev environment), but you'll have to install it manually.

[taylor.smock]

Plugin jar with fix for #21788/#22132

[taylor.smock]

Fixed with ​v0.6.10.