[RFC PATCH] add a possibility to add and remove from selection in lasso and rect mode

[dieterdreist]

Currently I can add objects from a selection in rectangle and lasso mode by holding shift, or when holding alt JOSM will select also ways that are partially in the selection area. But I cannot get it to deselect.
Strange enough, "ctrl" makes the screen pan on mouse drag (in FreeBSD and Linux this is typically done with "alt" for windows on the OS level, while many applications use "space"+drag to pan the working area), ctrl seems a bit strange for this.
Maybe it has to do with the broken modifier keys in MacOS (partially system conform, partially Java conform), I tried every key combination that came to mind but could not make it deselect.
What about adding a dedicated UI, something similar to how graphic programs work: you select the current selection mode with radio buttons between: replace, add, remove, (maybe toggle) and maybe also object type checkboxes (not radio buttons) for node, way, relation, and this would be the current selection mode if you do not hold any modifier keys (until you change the selection mode). Default is "replace" as it is now.

[skyper]

According to Help/Action/Select Ctrl should be the modifier for removing, at least in rectangle mode.

[taylor.smock]

Replying to skyper:

According to Help/Action/Select Ctrl should be the modifier for removing, at least in rectangle mode.

This is disabled on Mac. See source:trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java@HEAD:71,349#L349​.

EDIT: This appears to still be the case, see ​https://support.apple.com/guide/mac-help/right-click-mh35853/mac

[anonymous]

yes, what are ctrl actions on linux and windows, in MacGUI apps they consistently use the command-key instead of the ctrl key (e.g. copy and paste, cmd+o for opening etc.)
if it were possible rather then disable the rm action activate it with cmd on macs, that would be great (also from a general user experience point of view).

[taylor.smock]

Replying to anonymous:

yes, what are ctrl actions on linux and windows, in MacGUI apps they consistently use the command-key instead of the ctrl key (e.g. copy and paste, cmd+o for opening etc.)
if it were possible rather then disable the rm action activate it with cmd on macs, that would be great (also from a general user experience point of view).

Sorry, I should have been clearer, the command + left-click is still used to simulate right-click. Not ctrl + left-click.

[anonymous]

I just tried it, the command key is doing nothing in Josm select mode. In Firefox command has no effect on click (ctrl + click is like a right click in FF)

[taylor.smock]

Replying to anonymous:

I just tried it, the command key is doing nothing in Josm select mode. In Firefox command has no effect on click (ctrl + click is like a right click in FF)

My bad. I'm used to converting ctrl -> cmd for mac. It is ctrl + left-click that is the problem. I'll have to look and see if we are already converting ctrl to cmd for mac (most shortcuts already do this, I just don't know if we are doing it for mapmodes).

[taylor.smock]

I'm going to play around with the patch for a bit and give other OSX users a chance to tell us that cmd+click is used for some built-in Mac functionality that I don't know about.

[taylor.smock]

Looks like single item deselect was broken.

[taylor.smock]

Replace ctrl with platform specific equivalent in most places for SelectAction

[taylor.smock]

attachment:josm-custom.jar​ contains attachment:22065.2.patch​, along with some other modifications I've been playing with. Feel free (or not) to tell me whether or not a keyboard shortcut is broken in Mac OS X or any other platform.

[skyper]

Replying to taylor.smock:

attachment:josm-custom.jar​ contains attachment:22065.2.patch​, along with some other modifications I've been playing with. Feel free (or not) to tell me whether or not a keyboard shortcut is broken in Mac OS X or any other platform.

With a quick test on Linux, I miss the modifier keys listed in the most right field of the StatusBar when activating Lasso Mode thought this is probably nothing new but would be nice to have.

[taylor.smock]

Replying to skyper:

With a quick test on Linux, I miss the modifier keys listed in the most right field of the StatusBar when activating Lasso Mode thought this is probably nothing new but would be nice to have.

Yep. Nothing new. This behavior existed in r17345, and probably earlier.

[taylor.smock]

Fix no-help lasso

[taylor.smock]

Replying to skyper:

With a quick test on Linux, I miss the modifier keys listed in the most right field of the StatusBar when activating Lasso Mode thought this is probably nothing new but would be nice to have.

This is fixed in attachment:22065.3.patch​, but I think we do want to have some translators give feedback on it -- I'm trying to reuse strings, but I don't know if it breaks translation horribly.

[taylor.smock]

In 18456/josm:

Fix #22065: Mac users cannot deselect with ctrl

From the Mac OS HIG guidelines, "[as] much as possible,
avoid using the Control key as a modifier."

In this case, we were using ctrl to deselect elements (and
we disabled this on Mac), merge nodes, scale, and rotate.

All of those now use ⌘ (meta) instead of ctrl on Mac.