Modify ↓

Opened 15 years ago

Closed 15 years ago

#2185 closed defect (fixed)

[PATCH] Various cleanup

Reported by: bruce89 <bcowan@…> Owned by: framm
Priority: minor Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

Here is a rather large patch which does a fair bit of cleaning up.

  • Removal of unused imports
  • Cleanup of javadoc comments
  • Parametrisation
  • Removal of unneeded casts
  • Slight string change (use of degree symbol instead of "degree")
  • Removal of unused methods
  • Proper use of static methods
  • Removal of useless history dialogue
  • Removal of fairly useless map mode (the old image one)

I have ignored FileDrop.java, as I think it is beyond hope, and it's probably best to leave it since it is from elsewhere.

Also, world.jpg and history.png from images can be removed.

Feel free to ignore certain parts of this patch.

Attachments (1)

JOSM.patch.gz​ (14.2 KB ) - added by bruce89 15 years ago.
Patch

Download all attachments as: .zip

Change History (3)

by bruce89, 15 years ago

Attachment: JOSM.patch.gz​ added

Patch

comment:1 by anonymous, 15 years ago

Summary: Various cleanup → [PATCH] Various cleanup

comment:2 by stoecker, 15 years ago

Resolution: → fixed
Status: new → closed

I removed the degree sign change and the worldchooser and history dialog killing.

Applied in r1415.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.