Modify

Opened 2 years ago

Last modified 2 years ago

#21811 new defect

To Get Access Token, Failure causes OAUTH OKAY to Hide

Reported by: MrGadget2You Owned by: team
Priority: normal Milestone:
Component: Core Version: tested
Keywords: OAuth upload Cc:

Description (last modified by skyper)

So Newly joined, but I enter my Username and Password to allow path to be added.
This fails, but I can't press the OKAY button because it hides behind the 'Get An Access Token' entry form, and appears to freeze the program until you move the 'Get An Access Token' out of the way and press OKAY this will allow the cancel button on the 'Get An Access Token' form to be pressed.

From #21816:

What steps will reproduce the problem?

So Windows 10 PC (not laptop).

https://josm.openstreetmap.de/wiki/Download

select josm-setup.exe
I currently don't have a username or password set up - very important as the error doesn't occur if they do.
Press Download button
Make a change, I drew a building and set the tags
Press the upload Button Upload window opens
Fill in boxes.
Press 'Upload Changes'
"Get an Access Token for 'https.....'" window opens
Type username and password, 'help' and 'me' respectively
Press Authorise now
window 'OAuth authorisation failed' opens
Press Okay On my PC this works perfectly,
so I am baffled, the key difference is the use of a mouse on the PC and the Finger Pad thing under the keyboard on the Laptop.
The only way to on the PC to get the same result is to ignore the Okay button and select the Get an Access Token window which isn't being locked.
If I try selecting the Editor I get an alarm bell and it refuses to allow me to bring the window to the front.
So the issue is simply lock the "Get an Access Token for 'https.....'" when the 'OAuth authorisation failed' window opens.

What is the expected result?

The "Get an Access Token for 'https.....'" window shouldn't be able to be selected whilst the window 'OAuth authorisation failed' is open

What happens instead?

The "Get an Access Token for 'https.....'" window hides the 'OAuth authorisation failed' window.

Please provide any additional information below. Attach a screenshot if possible.

Revision:18360
Build-Date:2022-01-02 23:53:33

Identification: JOSM/1.5 (18360 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19043)
Memory Usage: 239 MB / 2036 MB (92 MB allocated, but free)
Java version: 17.0.1+12-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00) \Display1 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18360, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\HWConsole.exe]
Dataset consistency test: No problems found

Last errors/warnings:
- 00943.895 E: org.openstreetmap.josm.io.MissingOAuthAccessTokenException
- 00943.910 E: Authentication failed - <html>Failed to authenticate at the OSM server 'https://api.openstreetmap.org/api'.<br>You are using OAuth to authenticate but currently there is no<br>OAuth Access Token configured.<br>Please open the Preferences dialogue and generate or enter an Access Token.</html>
- 00963.224 E: org.openstreetmap.josm.gui.oauth.OsmOAuthAuthorizationException: Failed to authorise OAuth request  'DmK7607wGBREtgKKbg9liscqolLRBmoF7Qkbwp69'
- 00963.237 E: OAuth authorisation failed - <html>The automatic process for retrieving an OAuth Access Token<br>from the OSM server failed.<br><br>Please try again or choose another kind of authorisation process,<br>i.e. semi-automatic or manual authorisation.</html>
- 00967.858 E: org.openstreetmap.josm.gui.oauth.OsmOAuthAuthorizationException: Failed to authorise OAuth request  'IKHe1spWzZn6FXNc1RmzfzH30QXYFxPFs0u2rAhM'
- 00967.871 E: OAuth authorisation failed - <html>The automatic process for retrieving an OAuth Access Token<br>from the OSM server failed.<br><br>Please try again or choose another kind of authorisation process,<br>i.e. semi-automatic or manual authorisation.</html>
- 01287.827 E: org.openstreetmap.josm.gui.oauth.OsmOAuthAuthorizationException: Failed to authorise OAuth request  'hOL6tjpoCgQZvkEyuWqsdS0N25cHujsu9OfOrHuR'
- 01287.840 E: OAuth authorisation failed - <html>The automatic process for retrieving an OAuth Access Token<br>from the OSM server failed.<br><br>Please try again or choose another kind of authorisation process,<br>i.e. semi-automatic or manual authorisation.</html>
- 01785.018 E: org.openstreetmap.josm.io.MissingOAuthAccessTokenException
- 01785.031 E: Authentication failed - <html>Failed to authenticate at the OSM server 'https://api.openstreetmap.org/api'.<br>You are using OAuth to authenticate but currently there is no<br>OAuth Access Token configured.<br>Please open the Preferences dialogue and generate or enter an Access Token.</html>

Attachments (0)

Change History (7)

comment:1 by skyper, 2 years ago

Component: unspecifiedCore
Keywords: OAuth added
Milestone: 22.01

Duplicate of #16485 or #19435?


Thanks for your report, however your ticket is incomplete and therefore not helpful in its current form.

Please add all needed information according to this list:

  • The required parts of the Status Report from your JOSM.
  • Describe what behaviour you expected.
  • Describe what did happen instead.
  • Describe if and how the issue is reproducible.
  • Add any relevant information like error messages or screenshots.

To ensure that all technical relevant information is contained, create new tickets by clicking in JOSMs Main Menu on Helpsource:trunk/resources/images/bug.svg Report Bug.


Last edited 2 years ago by skyper (previous) (diff)

comment:2 by skyper, 2 years ago

Owner: changed from team to MrGadget2You
Status: newneedinfo

comment:3 by MrGadget2You, 2 years ago

The issue is highlighted by the fact that I didn't become a member using the main website route, which meant that the username and password I used to create the ticket wasn't acknowledged. I have now gone through the main web page and joined, so can raise the ticket.
But the issue is weird, because my windows based laptop hid the okay window to acknowledge the failed login behind the login window for the Ticket, which I couldn't see so the program gives the illusion of freezing, as I couldn't remove the ticket window because it's locked waiting for the hidden okay to proceed window to be accepted.

Really very strange.

So the process is :

Do not become a member through the normal route, download the josm software.

Make a change.

Press the upload button.

Type in username and password.

This will open the unable to raise the ticket, and a OKAY acknowledge login failure appears briefly before hiding.

comment:4 by skyper, 2 years ago

Owner: changed from MrGadget2You to team
Status: needinfonew

Thanks.

  • You need to have an account on OSM to upload which needs to be created prior to upload and outside of JOSM.
  • Your problem is similar to #19435 with hiding dialogs.
  • Your Status Report would still be useful, see the trick how to gather the needed information using Report Bug, in my last comment.

comment:5 by skyper, 2 years ago

Keywords: upload added

comment:6 by taylor.smock, 2 years ago

Ticket #21816 has been marked as a duplicate of this ticket.

comment:7 by skyper, 2 years ago

Description: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to MrGadget2You.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.