[patch] Request focus in SplitWayAction window segment list

[gaben]

When splitting a way in expert mode, a window appears for selecting the segment for history reuse. If you are not satisfied with the default selection (way with most nodes), currently you need to use the mouse to change it.

After adding this line, up/down keys will also be usable without further interaction to select the way, which speeds up editing.

src/org/openstreetmap/josm/actions/SplitWayAction.java

@@ -242 +242 @@
                 if (ds != null) {
                     ds.addDataSetListener(dataSetListener);
                 }
+                list.requestFocusInWindow();
             } else {
                 if (ds != null) {
                     ds.removeDataSetListener(dataSetListener);

[gaben]

up

[stoecker]

Milestone renamed

[taylor.smock]

In 18442/josm:

Fix #21792: Request focus in SplitWayAction window segment list (patch by gaben)

This allows users to use the arrow keys to select the way segment that will
keep history.

This should have no significant difference from a UI perspective, as previously
the OK button had focus, which prevented the arrow keys from working. With
this change, users can still use enter to activate the OK button.

One caveat is that space no longer works to activate the OK button without
using tab to change the focused component.

[taylor.smock]

Oops, I forgot to add patch by gaben to the commit message. Sorry. :(

EDIT: And fixed. Note to self, svn propedit svn:log --revprop -r<REVISION> works.

[gaben]

Thank you for applying the patch!

BTW we had space and enter for the same purpose ;)