Modify

Opened 4 months ago

Closed 2 weeks ago

Last modified 2 weeks ago

#21792 closed enhancement (fixed)

[patch] Request focus in SplitWayAction window segment list

Reported by: gaben Owned by: team
Priority: trivial Milestone: 22.05
Component: Core Version:
Keywords: focus Cc:

Description (last modified by gaben)

When splitting a way in expert mode, a window appears for selecting the segment for history reuse. If you are not satisfied with the default selection (way with most nodes), currently you need to use the mouse to change it.

After adding this line, up/down keys will also be usable without further interaction to select the way, which speeds up editing.

  • src/org/openstreetmap/josm/actions/SplitWayAction.java

     
    242242                if (ds != null) {
    243243                    ds.addDataSetListener(dataSetListener);
    244244                }
     245                list.requestFocusInWindow();
    245246            } else {
    246247                if (ds != null) {
    247248                    ds.removeDataSetListener(dataSetListener);

Attachments (0)

Change History (9)

comment:1 Changed 4 months ago by gaben

Description: modified (diff)

comment:2 Changed 4 months ago by gaben

Keywords: focus added

comment:3 Changed 2 months ago by gaben

Milestone: 22.03

comment:4 Changed 2 months ago by gaben

Description: modified (diff)

comment:5 Changed 7 weeks ago by stoecker

Milestone: 22.0322.04

comment:6 Changed 4 weeks ago by gaben

up

comment:7 Changed 2 weeks ago by stoecker

Milestone: 22.0422.05

Milestone renamed

comment:8 Changed 2 weeks ago by taylor.smock

Resolution: fixed
Status: newclosed

In 18442/josm:

Fix #21792: Request focus in SplitWayAction window segment list (patch by gaben)

This allows users to use the arrow keys to select the way segment that will
keep history.

This should have no significant difference from a UI perspective, as previously
the OK button had focus, which prevented the arrow keys from working. With
this change, users can still use enter to activate the OK button.

One caveat is that space no longer works to activate the OK button without
using tab to change the focused component.

comment:9 Changed 2 weeks ago by taylor.smock

Oops, I forgot to add patch by gaben to the commit message. Sorry. :(

EDIT: And fixed. Note to self, svn propedit svn:log --revprop -r<REVISION> works.

Last edited 2 weeks ago by taylor.smock (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.