IOOBE in OffsetUtils.getOffsetLocation

[CostelloMellow]

What steps will reproduce the problem?

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-01-02 21:24:43 +0100 (Sun, 02 Jan 2022)
Build-Date:2022-01-02 20:26:19
Revision:18360
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18360 en) Mac OS X 12.1
OS Build number: macOS 12.1 (21C52)
Memory Usage: 1885 MB / 3641 MB (303 MB allocated, but free)
Java version: 1.8.0_321-b07, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 1 2240×1260 (scaling 1.00×1.00) Display 2 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 2240×1260
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-686c8d55, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Dmacosx.jnlpx.dock.name=JOSM, -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-5988c3ea.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp , -Djnlpx.jvm="<java.home>/bin/java"]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (2.0.0-alpha.50)
+ apache-commons (35893)
+ apache-http (35893)
+ auto_tools (81)
+ easypresets (1623509627)
+ geochat (35893)
+ graphview (35893)
+ jna (35893)
+ mapwithai (1.9.8)
+ markseen (14)
+ osm-obj-info (66)
+ rex (53)
+ turnrestrictions (35893)
+ utilsplugin2 (35893)

Tagging presets:
+ <josm.userdata>/EasyPresets.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
+ https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Kaart-Styles.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
+ https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Overlapping%20Ways.mapcss
- ${HOME}/RefKaart-Styles.mapcss
- ${HOME}/RoadNamesKaart-Styles.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Validator rules:
+ https://raw.githubusercontent.com/KaartGroup/KaartValidator/master/kaart.validator.mapcss

Last errors/warnings:
- 02520.022 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An-lghaybTuEY2A4_xuZzG8RGt90V25nAUYjZdHaotIcMR4bQnodRKwJOY-pt-90FC_9Q7Vz2L-rVV_JxMouc5h56uUQjlajEK_J5_VxZ55aaB7y87ide8rqKbbXuZI3OLxO61ck38vaqbtXGsHbaw?stp=s2048x1152&ccb=10-5&oh=00_AT_zCwFBbLobKinA9oV6xPSH-4-YqlWojf_fhJdGuBHT1Q&oe=61F0BB3C&_nc_sid=122ab1. Listener not notified!
- 02854.046 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An-puwPED8kiF-YVfCN8h5WmM1rRvGXp6QA1kCeYFAqGYsXYteGNSwYQ-hNZN_0rClOtXDkTATkaF_nGnCVMXsTXF__Q9TovQk9hVzrePKk469NKb5xeRK30fNxsHwI44Ii_8Q0UgDf_UnuYlg-ixQ?stp=s2048x1152&ccb=10-5&oh=00_AT-af6VrasyCxzmyRSlK_uVcmsNwUH7hiCSCTzvO5iql6Q&oe=61EECFBB&_nc_sid=122ab1. Listener not notified!
- 02855.431 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An_lX2yQXy3yBA3O7Rd-fr7EOlntkRpV_8VjQMzoGDeC9o8EEUAAK5ULOWw-aGo9iwyBoTBZHf6G0Nb3r1U6sHRRvKL8ROjP_boiBfxbJVf1HNsKqb-yTEJtgVbPMaldiuSYnw9PlhvJnNWJ2AIaTxg?stp=s2048x1152&ccb=10-5&oh=00_AT9WYvTKb4RHbJGKXz9tXCRWU_HHzSTgS1a4w5BdzjKo7A&oe=61EF33BC&_nc_sid=122ab1. Listener not notified!
- 02856.550 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An9BjRJrfwjQAqCPNJmm5hFxluyyV3rsG7AbZLq0uGfe3G5e60wKxzw4Vng1ScO-CsneYL6w2NliwVKURIx1hZX4y6kgYBHyw84bQ_AAC-t1TXqiIDUN9ERhRUJh6RCbFKfWm-MiGWUtBld2lDXD6w?stp=s2048x1152&ccb=10-5&oh=00_AT-TdP5lD5zmRLTS_aYM5vj8h7vwF5cSRYAsAkDo4BnvEA&oe=61F01AD8&_nc_sid=122ab1. Listener not notified!
- 02864.100 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An_ZXUqge-W3RpQ1Tehcc_1Gn8WHxRLqAPvW8Bv7FhNPDlNBc6FXFUf_MQsSx0qu2qTtysaZ0Hor3sdBAUzYCAujQ5hoaW8iFXpWOELLklpKiQxxAgSz7lPE0swPBHerKw6seBZCZy656RTYkgJ5Sg?stp=s2048x1152&ccb=10-5&oh=00_AT9PCGxP0UJSYlOcUCWaImgbadN0seV3Z-W84v9DIGHyOQ&oe=61EF24EF&_nc_sid=122ab1. Listener not notified!
- 02866.246 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An_RNy6ijXFDuUibALZsT6ECaHsILmoikQgKEVLMj2m_-z2X4wl4L4gEYegRBoGS3ZHO3B7kkZyP99WgBtEkk8KjMcCtotCjMMrRDBDMg_kYD_zV-eQMKXtzKcjI7bvZFReq-1SM3WfWkZeNIBT2QA?stp=s2048x1152&ccb=10-5&oh=00_AT-G3-7Su0OGqYutLtuf5XTLFoLF4EipwaIKnCv0xqidOQ&oe=61EEEF12&_nc_sid=122ab1. Listener not notified!
- 02870.121 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An8yVS9eCpA28ei2GRGHrzPfZKxWOvv0YdQAlbQH_pIcVyH2IVA21tWdC1ZY2AE-KEznqkWirsE2XFCL0i9JUseMG-7YCjpwTsjtXOV5UgSPWpbCmVGA8qHS_PESGLUrUcpZHIr9AoswXriCGQq02gk?stp=s2048x1152&ccb=10-5&oh=00_AT_2DdpHBnEVO0wtsiGvON3jIEnfrngyG0q9csYihaKGpA&oe=61F04750&_nc_sid=122ab1. Listener not notified!
- 02872.338 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An__k4qn_dHbYn-4palOLEwSwh7zlntAmbClHc9TCu_R6SmYdMTH0BYUUy1g1ss5zP6-MrtU2olRdlet351VfPnM_ASkxXcArMwH7LIbmIN3-MZuJiCQyra5A5eshP2H0WfZYg4ghNJ6Hy7lnxw1V1c?stp=s2048x1152&ccb=10-5&oh=00_AT8gPzFEyB1tsrQgqSwQz6mQ3Kv-kApFgKu50nsi8Hq9rw&oe=61EFA260&_nc_sid=122ab1. Listener not notified!
- 02872.529 E: Handled by bug report queue: java.lang.IndexOutOfBoundsException: Index: 38, Size: 120
- 02875.239 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An_ixqiC4Q_XNsoRXxY6z5uq3WKtwlIBdFGe8eQFUumsLlZDkEe4_Z9PFaeKPGguiM2NJuG4KcpJJiT0JHKgqyleB3_iuZBTacgGAsbUmz3IMCZgPof3xOqppfEEi3OYSoUMWCjOg2xHgzjOcL1Bqx4?stp=s2048x1152&ccb=10-5&oh=00_AT_VxE6fpIXe57VfQoPgI4jJu8vF687eso8w6AJrfouKGA&oe=61F06D3C&_nc_sid=122ab1. Listener not notified!



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-2 (37) of javawsApplicationThreadGroup
java.lang.IndexOutOfBoundsException: Index: 38, Size: 120
	at java.util.ArrayList.rangeCheck(ArrayList.java:659)
	at java.util.ArrayList.get(ArrayList.java:435)
	at java.util.Collections$UnmodifiableList.get(Collections.java:1311)
	at org.openstreetmap.josm.data.vector.VectorWay.getNode(VectorWay.java:64)
	at org.openstreetmap.josm.data.vector.VectorWay.getNode(VectorWay.java:22)
	at org.openstreetmap.josm.plugins.mapillary.utils.OffsetUtils.getOffsetLocation(OffsetUtils.java:73)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.geoimage.MapillaryImageEntry.getPos(MapillaryImageEntry.java:353)
	at org.openstreetmap.josm.gui.layer.geoimage.ImageViewerDialog.displayImages(ImageViewerDialog.java:589)
	at org.openstreetmap.josm.gui.layer.geoimage.ImageViewerDialog.displayImage(ImageViewerDialog.java:572)
	at java.util.Optional.ifPresent(Optional.java:159)
	at org.openstreetmap.josm.plugins.mapillary.MapillaryLayerListener$ImageDialogListener.selectionChanged(MapillaryLayerListener.java:74)
	at org.openstreetmap.josm.data.vector.VectorDataSet.lambda$doSelectionChange$26(VectorDataSet.java:502)
	at org.openstreetmap.josm.tools.ListenerList.fireEvent(ListenerList.java:155)
	at org.openstreetmap.josm.data.vector.VectorDataSet.doSelectionChange(VectorDataSet.java:502)
	at org.openstreetmap.josm.data.vector.VectorDataSet.setSelectedImpl(VectorDataSet.java:445)
	at org.openstreetmap.josm.data.vector.VectorDataSet.setSelected(VectorDataSet.java:441)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.geoimage.MapillaryImageEntry.selectImage(MapillaryImageEntry.java:183)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.geoimage.MapillaryImageEntry.selectImage(MapillaryImageEntry.java:177)
	at org.openstreetmap.josm.gui.layer.geoimage.ImageViewerDialog$ImageAction.actionPerformed(ImageViewerDialog.java:260)
	at javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1668)
	at javax.swing.JComponent.processKeyBinding(JComponent.java:2882)
	at javax.swing.KeyboardManager.fireBinding(KeyboardManager.java:307)
	at javax.swing.KeyboardManager.fireKeyboardAction(KeyboardManager.java:263)
	at javax.swing.JComponent.processKeyBindingsForAllComponents(JComponent.java:2974)
	at javax.swing.JComponent.processKeyBindings(JComponent.java:2966)
	at javax.swing.JComponent.processKeyEvent(JComponent.java:2845)
	at java.awt.Component.processEvent(Component.java:6316)
	at java.awt.Container.processEvent(Container.java:2239)
	at java.awt.Component.dispatchEventImpl(Component.java:4889)
	at java.awt.Container.dispatchEventImpl(Container.java:2297)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1954)
	at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:835)
	at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1103)
	at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:974)
	at java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:800)
	at java.awt.Component.dispatchEventImpl(Component.java:4760)
	at java.awt.Container.dispatchEventImpl(Container.java:2297)
	at java.awt.Window.dispatchEventImpl(Window.java:2746)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:760)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:84)
	at java.awt.EventQueue$4.run(EventQueue.java:733)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:730)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

[taylor.smock]

This looks like it is probably a race condition.

java.lang.IndexOutOfBoundsException: Index: 38, Size: 120
Index: 38
Size: 120

Index > 0 and Index < Size.

Therefore, sometime between the bounds check and the throw, the size changes. And it is probably changing between the time where I get the index and where the range check happens (WAG).

[taylor.smock]

Hopefully fixed in ​f64142bfd16557718d0cba35ef1366888593b650.