Opened 2 years ago

Last modified 2 years ago

#21707 new enhancement

validator test for post_office:type=*

Reported by: leni Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: Cc:


With the approved proposal Proposed features/shop as post-partner: post_office:type=* is marked as deprecated.

It would be nice to add a validator-warning.

Attachments (0)

Change History (4)

comment:1 by skyper, 2 years ago

I think only deprecating is a bit shorthanded. We rather should add post_office=* to the preset. I am not sure how to handle post_office=post_partner and possible subkeys which can be added to all kinds of primary tags. Probably need an own preset without amenity=post_office but most of the other tags.

comment:2 by leni, 2 years ago

I agree, but it seems to me that the absence of a preset does not prevent the use of `post_office=* tags in JOSM ... on the other hand, the absence of a control allows the deprecated post_office:type=* tag to continue to be used.

That's why I put this evolution on "Core validator" to limit the use of this attribute, another request for improvement could concern "Internal Preset"

comment:3 by skyper, 2 years ago

JOSM does never prevent a tag to be used, besides some technical limits like no more than 255 characters.

In my eyes, it is a bad user experience if we warn about a deprecated tag which was never present in core and at the same time propose a new tag which is not available through presets.

Anyway, altogether should not be a big deal, besides icons and possible changes in style to support post services together with other shops. The latter is probably out of scope and needs a separate ticket.

comment:4 by leni, 2 years ago

You are right, it is better to suspend this control, to set up the preset (I am preparing the request); then, we should see the evolution of the data (post_office:type and post_office) in the database and determine if it is necessary to set up this warning.

Modify Ticket

Change Properties
Set your email in Preferences
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to leni.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.