NPE at org.openstreetmap.josm.gui.dialogs.ToggleDialog.detach

[jason.hurst@…]

What steps will reproduce the problem?

1. Clicking the pin on the Mapillary filter window

What is the expected result?

The Mapillary Filter window becomes unpinned.

What happens instead?

The error/bug window appears and the window remains "docked"

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-11-01 23:05:46 +0100 (Mon, 01 Nov 2021)
Build-Date:2021-11-01 22:25:18
Revision:18303
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18303 en) Mac OS X 10.16
OS Build number: macOS 11.6 (20G165)
Memory Usage: 3198 MB / 3641 MB (1634 MB allocated, but free)
Java version: 1.8.0_281-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatLightLaf
Screen: Display 69734208 1440×900 (scaling 1.00×1.00) Display 188945226 1920×1080 (scaling 1.00×1.00) Display 188945225 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-641ffd12, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Dmacosx.jnlpx.dock.name=JOSM, -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-32383d50.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp , -Djnlpx.jvm="<java.home>/bin/java"]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (2.0.0-alpha.50)
+ apache-commons (35524)
+ apache-http (35589)
+ auto_tools (81)
+ buildings_tools (35823)
+ easypresets (1623509627)
+ ejml (35458)
+ ext_tools (35640)
+ flatlaf (35862)
+ geotools (35458)
+ graphview (35640)
+ highwayNameModification (0.0.9)
+ imagery_offset_db (35640)
+ jaxb (35543)
+ jna (35872)
+ jogl (1.2.3)
+ jts (35458)
+ markseen (14)
+ opendata (35803)
+ osm-obj-info (66)
+ pdfimport (35640)
+ reltoolbox (35829)
+ reverter (35869)
+ rex (53)
+ scripting (30798)
+ turnrestrictions (35640)
+ utilsplugin2 (35856)

Tagging presets:
+ /Applications/JOSM-Buddy/assets/presets/heading.xml
+ ${HOME}/Desktop/heading.xml
+ <josm.userdata>/EasyPresets.xml

Map paint styles:
- ${HOME}/Desktop/applepaintstyles-main 4/main_street.mapcss
+ https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Kaart-Styles.mapcss
- https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Overlapping%20Ways.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- ${HOME}/Downloads/quandary_qc_backup.mapcss
- ${HOME}/Desktop/MX_Import Test .mapcss

Validator rules:
- https://raw.githubusercontent.com/KaartGroup/KaartValidator/master/kaart.durazno.validator.mapcss
+ /Applications/JOSM-Buddy/assets/validators/forbidden-tag-check.validator.mapcss
+ https://raw.githubusercontent.com/KaartGroup/KaartValidator/master/kaart.clingstone.validator.mapcss

Last errors/warnings:
- 03955.382 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An-K3LjdHTH-2BUu-yyBsY5hz-b_BQqKEuZ0zzVzUwHukt4pBlG5kt64ce9ScNO2Ximcbgtjg2qztXRKonA0LV685U-pJFWsFQye_580DED24TtSu2cDOlZV926GTPhzLli0XhN14j1gGOWhjSzeCRk?stp=s2048x1152&ccb=10-5&oh=00_AT_aW8fJ_lnY4MBnrNjh8BXzwxqdhyziAA_Ol-l9qkUr1g&oe=61C1B08D&_nc_sid=122ab1. Listener not notified!
- 04167.864 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An9n-vEZlbzrVFYJrpwK1-OKkrP7-zEPtPPfYj91oVKFcJkKHTOCdhWybP5MSe7M-C7DsO1NfVFcnGiU-dqx20tjHA3oHVPK-CoHQE4bjdGaeKWXtn8Py3lz80263l8FXRbnHHXxVr3SEPZiZ-czFA?stp=s2048x1152&ccb=10-5&oh=00_AT-ksJD_MpADIpOxsAjkvEAE20IthHJsoWY-6QgBWCN4QQ&oe=61C1265E&_nc_sid=122ab1. Listener not notified!
- 04184.916 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An9k58EDMvckqSXwMDdxvHRMDTQa8T_lnYJleCucwTmA_vRv0F8vf63db4nZhvXdYwdsaAaprDLfpFseLE9BqIPxFmdw4PQGnUxpeD-rs9Wp8GHZQm799jQ3Um3UV1BEiamNC3TBz4uNP3BBinJX-Q?stp=s2048x1152&ccb=10-5&oh=00_AT8VmGDGzRj0F7CVj2ezO9HPsfdbdLLhp8wUuGf9YCf6aw&oe=61C10F43&_nc_sid=122ab1. Listener not notified!
- 04270.324 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An_Tlyx4qX6hwl_0KKX6v9chgCCxPesHAZn4rKd3QkcmVRV69kN64GlTMMbOI6e1k3jRbEpN0AgnGXxPs1ObOKKmC-OND233Yiyc402MMYB2LV8m19Rln-SpFb2MKhgZtEJpZgnlNw6DwSM7Y_WOQUY?stp=s2048x1152&ccb=10-5&oh=00_AT86uC-avuVMviMq695y3w2Lz3cdLwSKErOlmdT0FiB6AQ&oe=61C1893F&_nc_sid=122ab1. Listener not notified!
- 04291.223 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An9-81Xyo5AgOBZKAMLXXrOoL-oQwQk-D5t1FHFIm46i5LefhvTIP8yQU-PDmqbx98Zhc4ZMyk7sUSVTY5jrNJ_uKWFMF_iwNDD1VeHjlRfW_pIaWC8FHR0tpOuFSftZ55jV3ta7JpyG3ZIK5gT2mME?stp=s2048x1152&ccb=10-5&oh=00_AT9v2BHCsBW_h91oAonOhKSjbK6MHaaCmWD5MkdsqXcHww&oe=61C15E9E&_nc_sid=122ab1. Listener not notified!
- 04360.447 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An_WnmiIOuvGVbAwu7OF0bZ9BHdFIoz1Lsqs9eG-PGvPVzwTuJPPkAj8FG5VBDrAr_gG2kVytPn2CoRw5Z2wYd_cVFzIFe6fwY55dYDGtiZwYet0wPs6LiDhX4EMYW0BbhZiVPP-7t0sbLmvU5YmKA?stp=s2048x1152&ccb=10-5&oh=00_AT-Tw1DFh1Z3eXevy2xv7j-YjTuM_OXo9Dn5435WLHO4QQ&oe=61C23E82&_nc_sid=122ab1. Listener not notified!
- 04361.344 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An8yIGKEu0oZj_BkwRITJCM9hKlhnokQbNrByYIjk8gdHBwFVQg8lM1Loft74BXlKkta9O4ux2PlZQylY88JW_D0IxMwnTdCb4_GXITINdTT5-1BUreDDKxg_omIR1jdOQ4xt86mzHuUFzGCi_S1uA?stp=s2048x1152&ccb=10-5&oh=00_AT9pfmg70h9WhPaz9ndXFMF_k9Ns7hLvtuOUOODJ-LjtcQ&oe=61C2ECEE&_nc_sid=122ab1. Listener not notified!
- 04403.475 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An855gXHIgSspKYGUDrV-HHhS88Z_J4rlFdI4Mq2jLd1wv281Ahm_X9jnifJfZUpsy2fNVsCck4Rv3VfMuWXLUAj87OqiMatuj6flaOPJkOubSjq3v7ZpbpDqGSWBouKnPtpq1-m9WbkHAmSEIfhxQ?stp=s2048x1152&ccb=10-5&oh=00_AT81DJtep-d_eWuSOIQD1zz2yZwANMLbevH2M4pFOBMZVA&oe=61C157AD&_nc_sid=122ab1. Listener not notified!
- 04460.783 E: Unknown detection "marking--discrete--text--30"
- 04490.163 E: Handled by bug report queue: java.lang.NullPointerException



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-2 (50) of javawsApplicationThreadGroup
java.lang.NullPointerException
	at org.openstreetmap.josm.gui.dialogs.ToggleDialog.detach(ToggleDialog.java:425)
	at org.openstreetmap.josm.gui.dialogs.ToggleDialog$TitleBar.lambda$new$4(ToggleDialog.java:602)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
	at java.awt.Component.processMouseEvent(Component.java:6539)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
	at java.awt.Component.processEvent(Component.java:6304)
	at java.awt.Container.processEvent(Container.java:2239)
	at java.awt.Component.dispatchEventImpl(Component.java:4889)
	at java.awt.Container.dispatchEventImpl(Container.java:2297)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4904)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4535)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4476)
	at java.awt.Container.dispatchEventImpl(Container.java:2283)
	at java.awt.Window.dispatchEventImpl(Window.java:2746)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:760)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:84)
	at java.awt.EventQueue$4.run(EventQueue.java:733)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:730)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

[skyper]

Mmh, similar to #19710, #20291 and #20475, all more or less "irreproducible".

[skyper]

Ticket #21714 has been marked as a duplicate of this ticket.

[skyper]

Replying to jason.hurst@…:

Identification: JOSM/1.5 (18303 en) Mac OS X 10.16
Java version: 1.8.0_281-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM

Might not solve it, but, please, update java to a current stable release. For macOS we currently recommend Java 17 which is include in the macOS package

[skyper]

Once again, the question if this is a core or mapillary plugin problem. Actually, I do not find mapillary in the log.

[taylor.smock]

Replying to skyper:

Once again, the question if this is a core or mapillary plugin problem. Actually, I do not find mapillary in the log.

In this case, I'm fairly certain it is Mapillary. The titlebar variable should only be null when the ToggleDialog is destroyed.

The only problem is that Mapillary appears to be properly destroying the instance of the ToggleDialog.

[taylor.smock]

I'm going to go ahead and close this -- we haven't seen any duplicates in the past few months.