Mapillary Plugin creates exception when unpinned

[Glassman]

What steps will reproduce the problem?

1. Install latest Mapillary Plugin
2. Download area
3. unpin Mapillary image window

What is the expected result?

Image window appears

What happens instead?

get "An unexpected exception occurred."

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-12-22 09:28:39 +0100 (Tue, 22 Dec 2020)
Revision:17423
Build-Date:2020-12-23 02:30:50
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17423 en) Linux Fedora 33 (Workstation Edition)
Memory Usage: 4100 MB / 8192 MB (3609 MB allocated, but free)
Java version: 11.0.9.1+1, Red Hat, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00) :0.1 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Desktop environment: GNOME
Java package: java-11-openjdk:x86_64-11.0.9.11
Environment variable LANG: en_US.UTF-8
VM arguments: [-Djosm.home=<josm.pref>]
Dataset consistency test: No problems found

Plugins:
+ EasyPresets (1604762161)
+ ImportImagePlugin (35567)
+ Mapillary (1.5.29)
+ OpeningHoursEditor (35640)
+ apache-commons (35524)
+ apache-http (35589)
+ auto_tools (73)
+ buildings_tools (35669)
+ ejml (35458)
+ geochat (35640)
+ geotools (35458)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ log4j (35458)
+ mapwithai-dev (1.7.1.1-9-g01f5f51)
+ measurement (35640)
+ opendata (35640)
+ osm-obj-info (56)
+ pdfimport (35640)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ reltoolbox (35640)
+ reverter (35640)
+ routing (35640)
+ tageditor (35640)
+ todo (30306)
+ turnlanes-tagging (288)
+ turnrestrictions (35640)
+ utilsplugin2 (35674)
+ wikipedia (1.1.4)

Tagging presets:
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/master/dist/name-suggestions.presets.xml
+ ${HOME}/Downloads/MikeN_Presets.zip
+ ${HOME}/Development/josm_sidewalk_presets/sidewalk_preset.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
+ ${HOME}/foo.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Kerbs&zip=1
- https://raw.githubusercontent.com/OpenSidewalks/OpenSidewalks-Schema/master/open_sidewalks.mapcss
+ ${HOME}/OSM/open_sidewalks2.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Last errors/warnings:
- 53167.129 E: Failed to locate image 'regulatory--texts--g1'
- 53167.129 E: Failed to locate image 'regulatory--texts--g2'
- 53167.136 E: Failed to locate image 'void--car-mount'
- 53167.137 E: Failed to locate image 'void--dynamic'
- 53167.137 E: Failed to locate image 'void--ego-vehicle'
- 53167.137 E: Failed to locate image 'void--ground'
- 53167.137 E: Failed to locate image 'void--static'
- 53167.150 E: Failed to locate image 'warning--kangaroo-crossing--g1'
- 53257.781 E: Handled by bug report queue: java.lang.NullPointerException
- 53294.240 E: Handled by bug report queue: java.lang.NullPointerException



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (30) of main
java.lang.NullPointerException
	at org.openstreetmap.josm.gui.dialogs.ToggleDialog.detach(ToggleDialog.java:422)
	at org.openstreetmap.josm.gui.dialogs.ToggleDialog$TitleBar.lambda$new$3(ToggleDialog.java:601)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1967)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2308)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
	at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:279)
	at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:297)
	at java.desktop/java.awt.Component.processMouseEvent(Component.java:6635)
	at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3342)
	at java.desktop/java.awt.Component.processEvent(Component.java:6400)
	at java.desktop/java.awt.Container.processEvent(Container.java:2263)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5011)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4918)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4547)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4488)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2307)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2772)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

[skyper]

Duplicate of #19710?

[taylor.smock]

Replying to skyper:

Duplicate of #19710?

Hopefully. It is a different stack trace, but the same location.

Also, there are steps to reproduce. :) (Thanks @Glassman for that)

[taylor.smock]

Hopefully fixed in ​b3dc8f42fae452cc131766f40543ca0a8837b9b0.

I was, again, unable to reproduce. However, since Glassman ran into it with this weeks release, it wasn't accidentally solved earlier.

Let me know if you run into it again with the next release of the plugin (v1.5.30). I'll be releasing v1.5.30 later today, as soon as the tests finish running and I merge the branch.

If you hit it again, can you do a more thorough steps to reproduce?
i.e., something like this:

1. Open JOSM
2. Install Mapillary
3. Restart JOSM
4. Download a new layer
5. Delete the new layer
6. Download a new layer
7. Unpin the Mapillary image dialog
8. Crash

(Note: that is what I did to try to reproduce, along with some variations)

[Glassman]

I think I may have better identified the sequence of steps to reproduce.

1. Open JOSM
2. Install Mapillary
3. Restart JOSM
4. Download a new layer
5. Unpin the Mapillary image dialog -> Causes exception
6. Download mapillary images
7. Unpin the Mapillary image dialog -> No exception

My original attempt was opening the Mapillary Image window before downloading the mapillary images.

Version 1.5.30 no longer causes the exception in the steps shown above. Thanks for the fix.