AE: a new instance needs to be created first (mapillary point objects)

[anonymous]

What steps will reproduce the problem?

1. add layer mapillary point objects
2. double click on pole
3. error

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-11-01 23:05:46 +0100 (Mon, 01 Nov 2021)
Revision:18303
Build-Date:2021-11-01 22:25:18
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18303 ru) Linux Ubuntu 20.04.3 LTS
Memory Usage: 1265 MB / 3922 MB (885 MB allocated, but free)
Java version: 11.0.11+9-Ubuntu-0ubuntu2.20.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.gtk.GTKLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: ru_UA.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: ru_UA
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: KDE
Java package: openjdk-11-jre:amd64-11.0.11+9-0ubuntu2~20.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-compress-java: libcommons-compress-java:all-1.19-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:all-20200323-1build1~ubuntu20.04.1
liboauth-signpost-java: liboauth-signpost-java:all-1.2.1.2-3
VM arguments: [-Djosm.restart=true, -Djava.net.useSystemProxies=true]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (35864)
+ ImproveOsm (215)
+ Mapillary (2.0.0-alpha.48)
+ apache-commons (35524)
+ apache-http (35589)
+ auto_tools (81)
+ buildings_tools (35823)
+ continuosDownload (99)
+ imagery_offset_db (35640)
+ jna (35662)
+ mapwithai (1.9.1)
+ measurement (35640)
+ pt_assistant (1ff2e15)
+ public_transport (35640)
+ reltoolbox (35829)
+ terracer (35827)
+ todo (30306)
+ undelete (35848)
+ utilsplugin2 (35856)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/MappingAccessibility&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Playground_Equipment&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportOneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/pedestrian_crossings_in_DE&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Historical_Objects&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/AdvertisingPreset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/TurnLanes&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
- https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksAndFootways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://raw.githubusercontent.com/OpenSidewalks/OpenSidewalks-Schema/master/open_sidewalks.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/NewParkingFeatures&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/iD&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Bench&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AdvertisingStyle&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
+ resource://mapcss/Mapillary.mapcss

Last errors/warnings:
- 01521.914 E: Handled by bug report queue: java.lang.OutOfMemoryError: Java heap space
- 05026.806 E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<You requested too many nodes (limit is 50000). Either request a smaller area, or use planet.osm>
- 05026.813 E: Неверный запрос - <html>Сервер OSM 'api.openstreetmap.org' сообщил о неудачном запросе.<br><br>Область, которую вы хотите скачать, слишком велика или запрошено слишком много данных.<br>Выделите меньшую область или воспользуйтесь средствами экспорта файлов OSM.</html>
- 05600.561 E: Не удалось найти изображение «mapillary_sprite_source/package_objects/object--traffic-sign--front»
- 05600.563 E: Не удалось найти изображение «mapillary_sprite_source/package_objects/object--traffic-sign--back»
- 05602.507 E: Не удалось найти изображение «mapillary_sprite_source/package_objects/object--traffic-sign--front»
- 05602.507 E: Не удалось найти изображение «mapillary_sprite_source/package_objects/object--traffic-sign--back»
- 05603.150 E: Не удалось найти изображение «mapillary_sprite_source/package_objects/object--traffic-sign--front»
- 05613.868 E: Не удалось найти изображение «mapillary_sprite_source/package_objects/object--traffic-sign--front»
- 05626.243 E: Handled by bug report queue: java.lang.AssertionError: a new instance needs to be created first



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (19) of main
java.lang.AssertionError: a new instance needs to be created first
	at org.openstreetmap.josm.gui.layer.geoimage.ImageViewerDialog.getInstance(ImageViewerDialog.java:109)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.PointObjectLayer.selectedMapFeatureChanged(PointObjectLayer.java:600)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.PointObjectLayer.selectionChanged(PointObjectLayer.java:364)
	at org.openstreetmap.josm.data.vector.VectorDataSet.lambda$doSelectionChange$26(VectorDataSet.java:502)
	at org.openstreetmap.josm.tools.ListenerList.fireEvent(ListenerList.java:155)
	at org.openstreetmap.josm.data.vector.VectorDataSet.doSelectionChange(VectorDataSet.java:502)
	at org.openstreetmap.josm.data.vector.VectorDataSet.setSelectedImpl(VectorDataSet.java:445)
	at org.openstreetmap.josm.data.vector.VectorDataSet.setSelected(VectorDataSet.java:436)
	at org.openstreetmap.josm.plugins.mapillary.gui.DataMouseListener.mouseClickedInner(DataMouseListener.java:66)
	at org.openstreetmap.josm.plugins.mapillary.gui.DataMouseListener.mouseClicked(DataMouseListener.java:49)
	at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:278)
	at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:277)
	at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:277)
	at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:277)
	at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:277)
	at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:277)
	at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:277)
	at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:277)
	at java.desktop/java.awt.Component.processMouseEvent(Component.java:6638)
	at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3342)
	at java.desktop/java.awt.Component.processEvent(Component.java:6400)
	at java.desktop/java.awt.Container.processEvent(Container.java:2263)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5011)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4918)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4556)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4488)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2307)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2772)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

[skyper]

Mapillary plugin or JOSM core?

[skyper]

Ticket #21611 has been marked as a duplicate of this ticket.

[taylor.smock]

Replying to skyper:

Mapillary plugin or JOSM core?

Kind of both. There is not hasInstance method in JOSM core, so I've got to guess. Elsewhere in the code, I've got something that checks for it, and creates it if it doesn't exist (using reflection).

See ​https://github.com/JOSM/Mapillary/blob/master/src/main/java/org/openstreetmap/josm/plugins/mapillary/utils/ReflectionUtils.java#L30-L45 for the code I wrote to get around the issue. Which I really need to upstream.

EDIT: That was for a subcomponent of the ImageViewerDialog. I'll move the code I used to ensure it was created to the mapFrameInitialized method in the main plugin class.

[taylor.smock]

Fixed in ​cb3c3cc5647df1c27439aa5fdfabb2f232e94038.