NPE in MapillarySequenceUtils#getNextOrPrevious

[anonymous]

What steps will reproduce the problem?

1. Comes up when clicking through images
2. For it not to come up while clicking through images
3. It comes up while clicking through images

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-11-01 23:05:46 +0100 (Mon, 01 Nov 2021)
Revision:18303
Build-Date:2021-11-01 22:25:18
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18303 en) Mac OS X 10.16
OS Build number: macOS 11.4 (20F71)
Memory Usage: 977 MB / 4096 MB (55 MB allocated, but free)
Java version: 11.0.10+9-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatDarculaLaf
Screen: Display 1 2240×1260 (scaling 2.00×2.00) Display 2 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 2240×1260
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop]
Dataset consistency test: No problems found

Plugins:
+ EasyPresets (1623509627)
+ Mapillary (2.0.0-alpha.44)
+ apache-commons (35524)
+ apache-http (35589)
+ auto_tools (81)
+ buildings_tools (35823)
+ changeset-viewer (25)
+ flatlaf (35862)
+ geochat (35640)
+ graphview (35640)
+ intersection (0.0.7)
+ jna (35662)
+ markseen (14)
+ measurement (35640)
+ openqa (0.2.2)
+ osm-obj-info (66)
+ rex (53)
+ turnrestrictions (35640)
+ utilsplugin2 (35856)

Tagging presets:
+ <josm.userdata>/EasyPresets.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
+ https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Kaart-Styles.mapcss
+ https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Overlapping%20Ways.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

Validator rules:
+ https://raw.githubusercontent.com/KaartGroup/KaartValidator/master/kaart.clingstone.validator.mapcss

Last errors/warnings:
- 02766.347 W: Unknown remote control parameter title, skipping it
- 02937.762 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An-No3_q8k4VizO2n-ySHu0C-BOPWoP1W2w9jS-V6992u8xr6izvXpPa2VV_ra-1abEesJdrqAcpXzu1E1kP9wgJ9y2NGaTIxcerAxvwH6AjP7sCsx371xN5czAiF8qgITB1olhkLcm-VU7T0pQk8UA?stp=s2048x1152&ccb=10-5&oh=17f92cdbd3535f0820733462e6e08bd9&oe=6196B109&_nc_sid=122ab1. Listener not notified!
- 02938.230 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An8_kNoWVNOQJuSsaAG3dC8Sd7mbEwZwSRH9YiwbcbEliZ471QoCzRLFILKLt2y2g9VpA0ckqi0jYhWuO38fSkX7bSLHQJOSTGR3N_q588_vjMHq6E5WhUbZ9ZArDghuEvSOV7wRJM7SsH8mHrLZiA?stp=s2048x1152&ccb=10-5&oh=91c75d3a14a8213de8322818b1bee18e&oe=619701A3&_nc_sid=122ab1. Listener not notified!
- 03092.923 E: Unknown detection "marking--discrete--arrow--other"
- 03093.431 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An-mmF-0IxSNivZ0xiC6mKy7mON2lmjF86K7JwdlMQY0RpS54jqRMKbjRXVyCO5VqLtNWZlgNSukfuc_CYvNgzXwrS3UaJJaeedL0avi9gtfom60CK9INJ5fpYgEUbDW9g1K5wM7bGh1ECO6CeMwHw?stp=s2048x1152&ccb=10-5&oh=9039b982f6611ead50b94b84711eccae&oe=61977854&_nc_sid=122ab1. Listener not notified!
- 03095.241 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An9GoRLGobFQPOZqL6mVLYefrFXMa4tWF8Woy9eQNGyE-BbmtwZqNpwFoKnXF82X-PJaGUDcukUKnNRtSSItdHp30KD3UEiNRlt0S-MVumGmSiWShD0BfNtWSARGVsSloyn_vMfybvBE9IhmmVHdTA?stp=s2048x1152&ccb=10-5&oh=03f277b26b495c1a16c8509a60fd2ee5&oe=61979023&_nc_sid=122ab1. Listener not notified!
- 03103.100 E: Unknown detection "marking--discrete--arrow--other"
- 03107.248 E: Handled by bug report queue: java.lang.NullPointerException
- 03113.071 W: Listener not found for URL: https://scontent.fmci2-1.fna.fbcdn.net/m1/v/t6/An9fIbpbnwgpw9mXOtPIiOof1_RTN3isrywYfXx1BeYJtA0frgeZD1fsUmZVksxkMO_S6mnL9sjhTO55JoWblh_g2zJlGXjHfSlgkgwE-fBbbBCGU1fW27IndiWLignDLNJVhC8AcXHDWienzyYY6So?stp=s2048x1152&ccb=10-5&oh=c408ebf534b6cc20dcd9c6266f36a3c6&oe=6197DBBB&_nc_sid=122ab1. Listener not notified!
- 03118.482 E: Unknown detection "marking--discrete--arrow--other"



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-1 (32) of JOSM
java.lang.NullPointerException
	at org.openstreetmap.josm.plugins.mapillary.utils.MapillarySequenceUtils.lambda$getNextOrPrevious$2(MapillarySequenceUtils.java:104)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:176)
	at java.base/java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1632)
	at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:127)
	at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:502)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:488)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
	at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:543)
	at org.openstreetmap.josm.plugins.mapillary.utils.MapillarySequenceUtils.getNextOrPrevious(MapillarySequenceUtils.java:104)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.geoimage.MapillaryImageEntry.getNextImage(MapillaryImageEntry.java:150)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.geoimage.MapillaryImageEntry.getNextImage(MapillaryImageEntry.java:68)
	at org.openstreetmap.josm.gui.layer.geoimage.ImageViewerDialog$ImageAction.updateEnabledState(ImageViewerDialog.java:279)
	at org.openstreetmap.josm.gui.layer.geoimage.ImageViewerDialog.displayImages(ImageViewerDialog.java:597)
	at org.openstreetmap.josm.gui.layer.geoimage.ImageViewerDialog.displayImage(ImageViewerDialog.java:572)
	at java.base/java.util.Optional.ifPresent(Optional.java:183)
	at org.openstreetmap.josm.plugins.mapillary.MapillaryLayerListener$ImageDialogListener.selectionChanged(MapillaryLayerListener.java:79)
	at org.openstreetmap.josm.data.vector.VectorDataSet.lambda$doSelectionChange$26(VectorDataSet.java:502)
	at org.openstreetmap.josm.tools.ListenerList.fireEvent(ListenerList.java:155)
	at org.openstreetmap.josm.data.vector.VectorDataSet.doSelectionChange(VectorDataSet.java:502)
	at org.openstreetmap.josm.data.vector.VectorDataSet.setSelectedImpl(VectorDataSet.java:445)
	at org.openstreetmap.josm.data.vector.VectorDataSet.setSelected(VectorDataSet.java:441)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.geoimage.MapillaryImageEntry.selectImage(MapillaryImageEntry.java:188)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.geoimage.MapillaryImageEntry.selectImage(MapillaryImageEntry.java:182)
	at org.openstreetmap.josm.gui.layer.geoimage.ImageViewerDialog$ImageAction.actionPerformed(ImageViewerDialog.java:260)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1967)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2308)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
	at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:279)
	at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:297)
	at java.desktop/java.awt.Component.processMouseEvent(Component.java:6635)
	at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3342)
	at java.desktop/java.awt.Component.processEvent(Component.java:6400)
	at java.desktop/java.awt.Container.processEvent(Container.java:2263)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5011)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4918)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4547)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4488)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2307)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2772)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

[taylor.smock]

Ticket #21564 has been marked as a duplicate of this ticket.

[taylor.smock]

This should be fixed in ​902676fe1f3a1471ab479415fcc06acb1d87d600.