Complain about water=river (or waterway=riverbank) with names

[mkoniecz]

What steps will reproduce the problem?

1. create closed way
2. tag it with name=AAA waterway=riverbank
3. run validator

What is the expected result?

Validator complain "names of rivers should be only on water=river line, create it if missing"

What happens instead?

Nothing

See for example ​https://www.openstreetmap.org/#map=17/51.31990/15.00388&layers=N

Please provide any additional information below. Attach a screenshot if possible.

Is it valid to have named lakes where river is flowing though tagged with water=river (or waterway=riverbank)?

In such case this rule would not be possible.

​https://taginfo.openstreetmap.org/tags/water=river#combinations indicated over 40 000 instances, what is surprising to me - as far as I know such tagging is considered as clearly invalid.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-09-13 01:17:23 +0200 (Mon, 13 Sep 2021)
Revision:18222
Build-Date:2021-09-13 01:31:03
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18222 en) Linux Ubuntu 20.04.3 LTS
Memory Usage: 438 MB / 3974 MB (289 MB allocated, but free)
Java version: 11.0.11+9-Ubuntu-0ubuntu2.20.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1200 (scaling 1.00×1.00) :0.1 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: LXQt
Java package: openjdk-11-jre:amd64-11.0.11+9-0ubuntu2~20.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (35823)
+ measurement (35640)
+ reverter (35732)
+ todo (30306)

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
+ ${HOME}/Documents/install_moje/OSM software/manual editing and discussions/josm/resources/data/validator/deprecated.mapcss

[zelonewolf@…]

If there is a named waterway intersecting a named river area, and the names are the same, it should auto fix remove the name from the river area.

If the names are different, the user should be prompted with a warning requiring manual fix.

If there is a named river area with no waterway=river present, it should warn the user that the river is missing.

[skyper]

All water=* which have a waterway=* with the same value should be check.

Replying to zelonewolf@…:

If there is a named waterway intersecting a named river area, and the names are the same, it should auto fix remove the name from the river area.

If the names are different, the user should be prompted with a warning requiring manual fix.

If there is a named river area with no waterway=river present, it should warn the user that the river is missing.

This will only work inside download area and even then there is a risk that the linear object is not downloaded if there are not any nodes in common.