Inconsistent selection behaviour of 'Add tag' dialog when using CTRL+A shortcut

[ff5722]

What steps will reproduce the problem?

1. Select an object and open the Add tag dialog using the CTRL+A shortcut

What is the expected result?

The tag or key is always pre-selected

What happens instead?

Sometimes the tag or key is selected, sometimes the cursor is at the end and nothing is selected. Curiously, when using the mouse to click on the Add tag button it always works fine as on previous versions.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-09-01 23:21:38 +0200 (Wed, 01 Sep 2021)
Build-Date:2021-09-01 22:22:21
Revision:18191
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18191 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19043)
Memory Usage: 884 MB / 2709 MB (572 MB allocated, but free)
Java version: 1.8.0_301-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00) \Display1 1080×1920 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1920
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ Create_grid_of_ways (35640)
+ FastDraw (35640)
+ Mapillary (2.0.0-alpha.33-dirty)
+ apache-commons (35524)
+ apache-http (35589)
+ buildings_tools (35756)
+ easypresets (1616854084)
+ ejml (35458)
+ geotools (35458)
+ gridify (1606242219)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ mapwithai (1.8.2)
+ opendata (35803)
+ reverter (35732)
+ terracer (35640)
+ utilsplugin2 (35792)

Tagging presets:
+ E:\Nextcloud\Documents\Openstreetmap\JOSM presets\CellTower.xml
+ E:\Nextcloud\Documents\Openstreetmap\JOSM presets\motorway_link.xml
+ E:\Nextcloud\Documents\Openstreetmap\JOSM presets\TunnelLayerPreset.xml
+ E:\Nextcloud\Documents\Openstreetmap\JOSM presets\BridgeLayerPreset.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Last errors/warnings:
- 00012.389 E: Failed to locate image 'MapWithAI'

[Don-vip]

Regression of #21240?

[skyper]

Yes, same on Debian Linux.

I already thought my keyboard is broken or that I type too fast.

[marcello@…]

I can see this behaviour when I hit Alt+A+A, (hold Alt and hit A twice). Or, if you hold A a little longer the keyboard will auto-repeat it for you.

The same happens if you fumble the Alt key while holding A down. That is: +Alt +A -Alt +Alt -A -Alt.

Or maybe your keyboard is broken. That would explain why you don't see this with the mouse.

Can we exclude all this?

[Don-vip]

Replying to skyper:

I already thought my keyboard is broken or that I type too fast.

Did you already face it before #21240?

[anonymous]

• Tried it on my other computer: can't replicate it there
• Tried it through remote desktop from another computer (to rule out the keyboard as I don't have a spare keyboard): still happening
• Tried with an empty/new preferences.xml: still happening
• Back on version 18118 the bug doesn't occur either

[Don-vip]

Who's speaking?

[ff5722]

That was me

[marcello@…]

If the reason for this is the keyboard fumble, it will be fixed along in an upcoming bigger patch of mine. If it is some weird timing thing it may take a bit longer.

[skyper]

Replying to Don-vip:

Replying to skyper:

I already thought my keyboard is broken or that I type too fast.

Did you already face it before #21240?

No, never had this issue before. Just tried r18171 and it does not happen.

Replying to marcello@…:

I can see this behaviour when I hit Alt+A+A, (hold Alt and hit A twice). Or, if you hold A a little longer the keyboard will auto-repeat it for you.

The same happens if you fumble the Alt key while holding A down. That is: +Alt +A -Alt +Alt -A -Alt.

Yes, I can reproduce.

Or maybe your keyboard is broken. That would explain why you don't see this with the mouse.

Just tried a different keyboard with no different outcome. I never use the mouse for "Add Tag" and I am rather typing too fast.

I tried it without any preferences and plugins and I am still able to reproduce. It seems to happen less frequently than with my bunch of plugins including flatlaf but it still happens. I tried to make sure that I only press the keys really short and precise but it still happens.

I have to say, that I usually use a gaming keyboard with short latency and rather quick repeat intervals and I know that there are problems with reaction time as keyboard fumbles have opened two blocking dialogs like "Add tag" and "Change value" at the same time but that is a different story.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-09-03 03:12:33 +0200 (Fri, 03 Sep 2021)
Revision:18193
Build-Date:2021-09-03 01:31:19
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18193 en) Linux Debian GNU/Linux 11 (bullseye)
Memory Usage: 145 MB / 256 MB (53 MB allocated, but free)
Java version: 17-ea+19-Debian-1, Debian, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Environment variable LANG: en_US.utf8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Desktop environment: GNOME
VM arguments: [-Djosm.home=<josm.pref>]

[marcello@…]

Does this still happen with version 18223?

[ff5722]

Seems to be completely fixed in 18225

Feel free to close this ticket if no further info is needed.

[skyper]

Cannot reproduce with r18225, thanks for fixing.

[skyper]

Ticket #21412 has been marked as a duplicate of this ticket.

[Don-vip]

Milestone renamed