Plugins/turnrestrictions : difference between the wiki and the plugin

[leni]

In the TurnRestrictions wiki it says "in the preference dialog you can also configure the shortcut to create/edit a turn restriction..."; whereas in the preferences it doesn't exist

I guess the plugin has removed the option, should the wiki be changed or the other way around?

[leni]

Preferences without shortcut

[skyper]

I did not check but is it not possible to change the shortcut for the action under Help/Preferences/Shortcuts like all other actions? Maybe, the plugin wiki page needs to point/link to the shortcut preferences wiki page?

[mdk]

The screenshot in the wiki is an older version (before reorganisation of the preferences). And even in "Expert Mode" the shortcut editing part is missing. This makes sense, as there is a separate editor for shortcuts, as skyper mentioned. But the Shortcut for the TurnRestrictions plugin are missing in the Shortcuts page.
So it's not only an outdated wiki page, but also a wrong or missing registration of the shortcut from the plugin code.

[leni]

So if I understand correctly, there are several points to consider:

1. change the text on the wiki page
2. ask for the removal of

with preferences-withoutShortCut.png (attached to this ticket)

3. modify the plugin or JOSM to be able to change the TurnRestrictions keyboard shortcuts in Help/Preferences/Shortcuts

For 1: I can do it, I'm making some changes before translating it.

For 2 and/or 3: I need to make a new ticket?

[skyper]

For 3., a new ticket (defect) with status report and a link to this ticket is the cleanest solution.

For 1. and 2., this ticket will do, in fact, I just have updated the wiki page concerning use of old syntax and the paragraph about the shortcut (diff). Did not take a deeper look at the contents of the rest of the page, though.

[leni]

Replying to skyper:

For 3., a new ticket (defect) with status report and a link to this ticket is the cleanest solution.

For 3. the new ticket is #21245

For 1. and 2., this ticket will do, in fact, I just have updated the wiki page concerning use of old syntax and the paragraph about the shortcut (diff). Did not take a deeper look at the contents of the rest of the page, though.

For 2. Thank for updated the wiki
For 1. the ticket remains open

[skyper]

What is left for 1.?

[leni]

Replying to skyper:

What is left for 1.?

Nothing, sorry, I didn't see that you had changed the link to the screen in the wiki, I thought the screen would be changed with the same name

[skyper]

Usually, it is better to keep the old image and adjust the image path to the new one. If you believe an attachment should be deleted for good, report it as spam (top left) with a useful comment.

[leni]

Replying to skyper:

Usually, it is better to keep the old image and adjust the image path to the new one.

To keep the history? I haven't seen it much.
So it would be better to put a version number or the wiki page where it is modified.
Won't it be cumbersome to keep all the images?
Only for the English version or for the translations as well?

If you believe an attachment should be deleted for good, report it as spam (top left) with a useful comment.

If we delete the old image, why change the name?

[skyper]

Yes, to keep the history working like version 47 of the plugin page.
Another reason is that changes on the page, e.g. the image path, are tracked with the version system plus diffs while replacing an attachment is only visible through the time stamp and translators get no indication about the change.