DataIntegrityProblemException: Deleted node referenced at org.openstreetmap.josm.data.osm.Way.checkNodes (delete action) after undo

[anonymous]

What steps will reproduce the problem?

1. I hit the undo hotkeys (cmmd+z) and the bug report warning popped up

What is the expected result?

To just undo and not prompt me with a warning

What happens instead?

See number 1

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-08-07 00:40:05 +0200 (Sat, 07 Aug 2021)
Revision:18128
Build-Date:2021-08-07 01:31:01
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18128 en) Mac OS X 10.16
OS Build number: macOS 11.5.1 (20G80)
Memory Usage: 1083 MB / 2048 MB (162 MB allocated, but free)
Java version: 11.0.10+9, AdoptOpenJDK, OpenJDK 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 188945226 1920×1080 (scaling 1.00×1.00) Display 69945736 2048×1152 (scaling 2.00×2.00)
Maximum Screen Size: 2048×1152
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [--add-modules=java.scripting,java.sql, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop,ALL-UNNAMED, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop]
Dataset consistency test: No problems found

Plugins:
+ apache-commons (35524)
+ apache-http (35589)
+ auto_tools (79)
+ buildings_tools (35756)
+ jna (35662)
+ mapwithai (1.8.2)
+ measurement (35640)
+ osm-obj-info (66)
+ utilsplugin2 (35792)

Tagging presets:
+ ${HOME}/Desktop/FB_presets.max (2).xml

Map paint styles:
+ ${HOME}/Desktop/FB_style.mapcss
+ ${HOME}/Desktop/Vietnam JOSM stuff/Updated Styles/rainbow_roads.mapcss
+ ${HOME}/Desktop/Sneffelsgems8.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Validator rules:
+ ${HOME}/Desktop/Vietnam JOSM stuff/FB_rules5.13.validator.mapcss
- ${HOME}/Desktop/Vietnam JOSM stuff/FB_rules5.14.validator.mapcss

Last errors/warnings:
- 24292.622 W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- 24294.215 W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- 24431.553 W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- 24551.694 W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- 24609.426 W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- 24609.444 W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- 24609.926 W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- 24609.945 W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- 24624.919 W: Unable to convert property color to type class java.awt.Color: found Keyword{transparent} of type class org.openstreetmap.josm.gui.mappaint.Keyword!
- 25315.346 E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Deleted node referenced: {Way id=-4601565447956728782 version=0 MVT nodes=[{Node id=-4610856038984571857 version=0 MVD lat=37.90240246533783,lon=-122.53890831207585}, {Node id=-4610856038984573511 version=0 MVD lat=37.902466242689634,lon=-122.53883113662187}, {Node id=-4610856038984573509 version=0 MVD lat=37.90249330739,lon=-122.53879838625251}, {Node id=-4610856038984570207 version=0 MVD lat=37.902527659774414,lon=-122.53875681720756}, {Node id=-4610856038984570038 version=0 MVD lat=37.902488745658935,lon=-122.53870516640777}, {Node id=-4610856038984571080 version=0 MVD lat=37.902459637157556,lon=-122.53874038993085}, {Node id=-4610856038984571686 version=0 MVD lat=37.90243663311391,lon=-122.5387098566329}, {Node id=-4610856038984572028 version=0 MVD lat=37.902363063408174,lon=-122.53879888153935}, {Node id=-4610856038984571593 version=0 MVD lat=37.90236818298769,lon=-122.53880567675645}, {Node id=-4610856038984569943 version=0 MVD lat=37.902345666663535,lon=-122.5388329231952}, {Node id=-4610856038984571857 version=0 MVD lat=37.90240246533783,lon=-122.53890831207585}]} (changed by the following commands: [Sequence: Orthogonalize], [Sequence: Orthogonalize], [Sequence: Merge 3 nodes], [Sequence: Orthogonalize], [Sequence: Extrude Way], [Sequence: Add node into way], [Sequence: Add node into way])



=== REPORTED CRASH DATA ===
sequence_information:
 - sequence_name: Sequence: Extrude Way
 - sequence_command: Change nodes of ‎building‎ (10 nodes)‌
 - sequence_index: 2
 - sequence_commands: [org.openstreetmap.josm.command.AddCommand;org.openstreetmap.josm.command.AddCommand;org.openstreetmap.josm.command.ChangeNodesCommand]
 - sequence_commands_descriptions: [Add node node;Add node node;Change nodes of ‎building‎ (10 nodes)‌]

BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-1 (53) of JOSM (development version)
org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Deleted node referenced: {Way id=-4601565447956728782 version=0 MVT nodes=[{Node id=-4610856038984571857 version=0 MVD lat=37.90240246533783,lon=-122.53890831207585}, {Node id=-4610856038984573511 version=0 MVD lat=37.902466242689634,lon=-122.53883113662187}, {Node id=-4610856038984573509 version=0 MVD lat=37.90249330739,lon=-122.53879838625251}, {Node id=-4610856038984570207 version=0 MVD lat=37.902527659774414,lon=-122.53875681720756}, {Node id=-4610856038984570038 version=0 MVD lat=37.902488745658935,lon=-122.53870516640777}, {Node id=-4610856038984571080 version=0 MVD lat=37.902459637157556,lon=-122.53874038993085}, {Node id=-4610856038984571686 version=0 MVD lat=37.90243663311391,lon=-122.5387098566329}, {Node id=-4610856038984572028 version=0 MVD lat=37.902363063408174,lon=-122.53879888153935}, {Node id=-4610856038984571593 version=0 MVD lat=37.90236818298769,lon=-122.53880567675645}, {Node id=-4610856038984569943 version=0 MVD lat=37.902345666663535,lon=-122.5388329231952}, {Node id=-4610856038984571857 version=0 MVD lat=37.90240246533783,lon=-122.53890831207585}]} (changed by the following commands: [Sequence: Orthogonalize], [Sequence: Orthogonalize], [Sequence: Merge 3 nodes], [Sequence: Orthogonalize], [Sequence: Extrude Way], [Sequence: Add node into way], [Sequence: Add node into way])
	at org.openstreetmap.josm.data.osm.Way.checkNodes(Way.java:553)
	at org.openstreetmap.josm.data.osm.Way.fireNodesChanged(Way.java:571)
	at org.openstreetmap.josm.data.osm.Way.setNodes(Way.java:67)
	at org.openstreetmap.josm.data.osm.Way.load(Way.java:282)
	at org.openstreetmap.josm.command.Command.undoCommand(Command.java:171)
	at org.openstreetmap.josm.command.SequenceCommand.undoCommands(SequenceCommand.java:138)
	at org.openstreetmap.josm.command.SequenceCommand.undoCommand(SequenceCommand.java:167)
	at org.openstreetmap.josm.data.UndoRedoHandler.lambda$undo$0(UndoRedoHandler.java:381)
	at org.openstreetmap.josm.gui.util.GuiHelper.runInEDTAndWait(GuiHelper.java:224)
	at org.openstreetmap.josm.data.UndoRedoHandler.undo(UndoRedoHandler.java:372)
	at org.openstreetmap.josm.data.UndoRedoHandler.undo(UndoRedoHandler.java:362)
	at org.openstreetmap.josm.actions.UndoAction.actionPerformed(UndoAction.java:39)
	at java.desktop/javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1810)
	at java.desktop/javax.swing.JComponent.processKeyBinding(JComponent.java:2900)
	at java.desktop/javax.swing.KeyboardManager.fireBinding(KeyboardManager.java:311)
	at java.desktop/javax.swing.KeyboardManager.fireKeyboardAction(KeyboardManager.java:266)
	at java.desktop/javax.swing.JComponent.processKeyBindingsForAllComponents(JComponent.java:2993)
	at java.desktop/javax.swing.JComponent.processKeyBindings(JComponent.java:2985)
	at java.desktop/javax.swing.JComponent.processKeyEvent(JComponent.java:2862)
	at java.desktop/java.awt.Component.processEvent(Component.java:6412)
	at java.desktop/java.awt.Container.processEvent(Container.java:2263)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5011)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1950)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:870)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1139)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:1009)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:835)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4892)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2772)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

[skyper]

What action do you try to undo? Please, take a look at the command stack panel.
Is it reproducible? How? Please tell as detailed as possible, step by step how to get this data inconsistency.

[skyper]

Similar to #21200.

[taylor.smock]

I asked the bug reporter about this (for steps to reproduce), and this is what they said:

It happened only once before, this was from hitting undo (cmmd+z) and I think it only occurs when I hit it in quickly and several times (3?+).
Aside from that it doesn’t pop up, it seems pretty specific and overall not too much of an issue but I figured I create the ticket anyway.

I'll see if I can get people here (at Kaart) to put their email in the email/username field, just so that they actually get notifications relatively quickly, if we need more information.

[taylor.smock]

Ticket #22089 has been marked as a duplicate of this ticket.

[taylor.smock]

OK. I sat down with the reporter for #22089, and they have only been editing buildings added from MapWithAI.

+ mapwithai (1.9.10)

This should have had better handling for bug reports. I'll have to investigate. :(