[patch] Tagging presets: Align text behind icons and center icons

[skyper]

What steps will reproduce the problem?

1. Have a preset with icons in front of keys or within <list_entry />

What is the expected result?

Icons are centered and the text behind the icons is aligned plus empty space is added for missing items

What happens instead?

Except of preset menu, no empty space for missing icons and the text is not aligned
Even in preset menu the icons are not centered

Please provide any additional information below. Attach a screenshot if possible.

So the syntax for menu has to be used for all places where icons plus text is listed below each other and additionally all icons should be centered.

Similar problem exists in preferences: #21208

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-08-06 01:22:18 +0200 (Fri, 06 Aug 2021)
Revision:18126
Build-Date:2021-08-06 01:31:59
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18126 en) Linux Debian GNU/Linux 10 (buster)
Memory Usage: 160 MB / 256 MB (19 MB allocated, but free)
Java version: 11.0.12+7-post-Debian-2deb10u1, Debian, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Desktop environment: GNOME

Plugins:
+ flatlaf (35799)
+ tagging-preset-tester (35640)

Tagging presets:
+ ${HOME}/JOSM/new/resources/data/defaultpresets_18096_20102.xml

[skyper]

screenshot of menu without centered icons

[skyper]

screenshot with unaligned entries

[skyper]

Please, be aware of #20008.

[gaben]

The 21207.patch​ fixes this (#21207) and also #21208.

[gaben]

Sorry, I forgot the explanation. Instead of rendering the icons as they are, rendering with bounds resolves the issue.

If there is no icon, a transparent icon is placed there instead. See "Shoulder" on the first image in this report.

[gaben]

with the patch

[stoecker]

Apply?

[gaben]

In 19657/josm:

fix #21208, fix #21207 - center icons and align text in preference and preset lists

Use padded icons for tagging preset icons and for list entry/label icons in the preset dialog, so non-square icons are centered and the texts line up. List entries without an icon get a blank one if other entries of the list have an icon.