Modify ↓

Opened 4 years ago

Last modified 4 years ago

#21129 new enhancement

Warn about missing primary key for all known relations

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report relation primary key Cc:

Description (last modified by skyper)

What steps will reproduce the problem?

  1. Have a site or destination_sign (see #21285) relation with only type=* and name=*
  2. Run validator

What is the expected result?

A warning about missing primary key

What happens instead?

No warning

Please provide any additional information below. Attach a screenshot if possible.

This came up in #20902.
Some relation types already have intensive validations but some like the two above (and likely a few more) miss a test for the primary key, so far.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-07-16 23:15:08 +0200 (Fri, 16 Jul 2021)
Revision:18045
Build-Date:2021-07-17 01:31:02
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (0)

Change History (1)

comment:1 by skyper, 4 years ago

Description: modified (diff)

destination_sign and building are dealt with in #21285. site needs an own, specific warning or might be added to the java code for MPs.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to skyper.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.