Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#21078 closed defect (fixed)

TagInfoExtract: External presets tags missing

Reported by: skyper Owned by: team
Priority: normal Milestone: 21.07
Component: Core Version:
Keywords: taginfo presets Cc: simon04

Description (last modified by skyper)

This is a follow-up of #19074, see my comment:6:

Replying to Klumbumbus:

It is not yet working: https://taginfo.openstreetmap.org/keys/addr%3Asuburb#projects

Could there be a problem with colons as taginfo:keys/bollard#projects and taginfo:keys/leaf_cycle#projects work.

It seems as quite some keys and tags from external presets are missing in the extract, especially, keys with colon (:) or underscore (_) are not included.

Take a look at Presets/IsSidepath and keys/is_sidepath#projects or Presets/LaneAttributes and keys/turn:both_ways#projects.

Attachments (0)

Change History (11)

comment:1 by skyper, 4 years ago

Cc: simon04 added

comment:2 by skyper, 4 years ago

Presets/PublicTransportGtfs is another example which is missing completely.

comment:3 by skyper, 4 years ago

Description: modified (diff)

comment:4 by skyper, 4 years ago

Description: modified (diff)

comment:5 by Don-vip, 4 years ago

Logs of IsSidePath:

2021-07-10 18:25:38.048 INFOS: Loading https://josm.openstreetmap.de/josmfile?page=Presets/IsSidepath&zip=1
2021-07-10 18:25:38.102 INFOS: GET https://josm.openstreetmap.de/josmfile?page=Presets/IsSidepath&zip=1 -> HTTP/1.1 200 (53 ms; 820 B)
2021-07-10 18:25:38.109 INFOS: Converting 0 presets of is_sidepath

comment:6 by Don-vip, 4 years ago

Component: CoreExternal preset

For IsSidePath, the tags are ignored because of the match=key. It should probably be defined to match=key! instead.

Probably the same issue for other presets.

in reply to:  6 comment:7 by skyper, 4 years ago

I see, according to #19074, optional tags for external presets are excluded but does match work for all cases, especially, with the new match_expression in mind?

Replying to Don-vip:

For IsSidePath, the tags are ignored because of the match=key. It should probably be defined to match=key! instead.

No, this does not work as is_sidepath=* is not needed/used in all cases.

I would need separate presets for each key then which might work for is_sidepath but definitely not for the two other presets.

comment:8 by skyper, 4 years ago

With r17977 in mind the restriction of excluding optional keys/tags from external presets might be dropped.

comment:9 by Don-vip, 4 years ago

Resolution: fixed
Status: newclosed

In 18016/josm:

fix #21078 - see #19074 - TagInfoExtract: include optional tags for external presets too (revert of r16386)

comment:10 by Don-vip, 4 years ago

Component: External presetCore
Milestone: 21.07

comment:11 by skyper, 4 years ago

Thanks a lot.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.