Image viewer: Colorfulness not working if image has only few colors

[skyper]

Edit: Sorry, I was wrong:

What steps will reproduce the problem?

1. Have a geoimage layer
2. In image viewer play around with color setting set colorfullness to least (black & white)
3. Jump through the images with "next" / "previous"

What is the expected result?

Colorfulness is adjusted right away to only gray scale

What happens instead?

Colorfulness setting stopped working completely after resetting color to "normal" only works with certain images. Gamma and Sharpness are still always working

Please provide any additional information below. Attach a screenshot if possible.

It did previous work in this session and I got the images displayed without color but after resetting it does not work anymore.

Additionally, the tooltip of the button is incorrect Change visibility of selected layer and I don't know what the "Layer" checkbox is about as there is no tooltip and for me it is always unchecked and clicking on it does not change anything.

Anyway, thanks a lot for this new feature.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-06-28 23:03:35 +0200 (Mon, 28 Jun 2021)
Revision:17943
Build-Date:2021-06-29 01:31:02
URL:https://josm.openstreetmap.de/svn/trunk

[skyper]

Strange, after continuing to work and deleting some images from the layer it is working with some images again, but unlike the other two settings it is not used for all images jumping to next and previous and it does not work with many images.

[skyper]

Sorry, I was wrong it simply does not work with all images. Suspect the problem is related to the spectrum of colors and with few colors it does not work.

[Bjoeni]

Closed as duplicate of #21016.
This is (hopefully) gonna be fixed in the referenced ticket with the new doFilterRGB() method:

This method also works with BufferedImage.TYPE_CUSTOM, which became more relevant since the filters can be applied to the image viewer since #20659.

Because especially for *.tiff images it currently doesn't work at all.

[skyper]

Replying to skyper:

Please provide any additional information below. Attach a screenshot if possible.

Additionally, the tooltip of the button is incorrect Change visibility of selected layer and I don't know what the "Layer" checkbox is about as there is no tooltip and for me it is always unchecked and clicking on it does not change anything.

See #21104.