Modify

Opened 14 months ago

Closed 13 months ago

Last modified 11 months ago

#20659 closed enhancement (fixed)

Add contrast/gamma/... on image viewer

Reported by: StephaneP Owned by: simon04
Priority: normal Milestone: 21.04
Component: Core image mapping Version:
Keywords: image, filters Cc:

Description (last modified by StephaneP)

Hi!

Sometimes street images can be too dark. It would be nice if the filters available on the aerial images could be available on the images viewer too. This, with an option to keep the setting when switching from one image to another.

Example with some filters (gamma, shadows highlight...) from Jpegview (GPL) :


Attachments (2)

image_filter_for_josm.jpg (97.0 KB) - added by StephaneP 14 months ago.
Screenshot 2021-04-03 at 23.12.58.jpg (145.3 KB) - added by simon04 14 months ago.

Download all attachments as: .zip

Change History (21)

Changed 14 months ago by StephaneP

Attachment: image_filter_for_josm.jpg added

comment:1 Changed 14 months ago by StephaneP

Description: modified (diff)

comment:2 Changed 14 months ago by anonymous

This would be awesome to have, although I wish that eventually there's a way to save those changes pwith the imagery provider

Changed 14 months ago by simon04

comment:3 Changed 14 months ago by simon04

Milestone: 21.04
Owner: changed from team to simon04
Status: newassigned


comment:4 Changed 14 months ago by StephaneP

Nice!

comment:5 Changed 14 months ago by skyper

+1, yes, nice.

Why not include single colors (RGB), too?
Are there plans to save the settings in order to reuse it for the next images or the next session?

comment:6 Changed 14 months ago by simon04

The color filter sets the corresponding color on the data layer which influences its rendering. There is no such concept for photos. To be honest, I don't see why this would be useful. Would you take a picture of a rainbow flag and view it in blue only? Or take a picture of a lake and transform it to a volcano red? ;-)

comment:7 Changed 14 months ago by skyper

Please, take color blindness into your thoughts. Contrast alone does not work in all cases and, yes, I would like to work with bluish images if I could see more details.

Last edited 14 months ago by skyper (previous) (diff)

comment:8 Changed 14 months ago by simon04

I haven't found a single ticket concerning "accessibility" or "blindness". I don't want to spend a lot of time on features that might make JOSM more accessible without any bigger picture or user feedback first.

comment:9 Changed 14 months ago by simon04

Resolution: fixed
Status: assignedclosed

In 17740/josm:

fix #20659 - Add contrast/gamma/... on image viewer

comment:10 Changed 14 months ago by simon04

In 17741/josm:

see #20659 - Extract LayerVisibilityAction.ColorSelector.getColors

comment:11 Changed 14 months ago by StephaneP

I'm testing Josm 17755. My comments:

  • I like that!! Thanks!
  • Colorfulness doesn't change the image colors
  • pressing the alt key close the window. Is it a normal behaviour?
  • We can't move the window. IMHO it's not a big deal on a large screen.

More important: There is no easy way to enable/disable these corrections. Is it possible to add a control on the image viewer, to enable/disable them?

comment:12 in reply to:  11 Changed 14 months ago by Klumbumbus

Replying to StephaneP:

  • pressing the alt key close the window. Is it a normal behaviour?

Yes, it is the same with all other "popup dialogs".

comment:13 in reply to:  11 Changed 14 months ago by Klumbumbus

Resolution: fixed
Status: closedreopened

Replying to StephaneP:

  • Colorfulness doesn't change the image colors

For me as well.

comment:14 Changed 14 months ago by StephaneP

Hi!

When the image is modified with one of the settings, pan and zoom becomes very slow.

comment:15 Changed 13 months ago by simon04

In 17828/josm:

see #20659 - Image viewer: apply filters when loading, not when rendering

This fixes:

  • ineffective colorfulness filter
  • performance when panning/zooming

comment:16 Changed 13 months ago by simon04

Resolution: fixed
Status: reopenedclosed

comment:17 in reply to:  15 Changed 13 months ago by StephaneP

Replying to simon04:
Thank you simon04 !

I have one question : does these filters could slow down Josm when we scroll fast thru an image sequence like I described on #20799?

comment:18 Changed 13 months ago by simon04

They should not as implementations of org.openstreetmap.josm.tools.ImageProcessor#process return the original image unless their value/slider has been changed.

comment:19 Changed 11 months ago by Don-vip

In 18018/josm:

fix #21104 - see #20659 - Image viewer: fix tooltips and icon size, hide layer-specific visibility checkbox

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.