Opened 4 years ago
Closed 4 years ago
#21024 closed enhancement (fixed)
Mapillary image info: add additonal information (~~camera make/model~~, image detections, ~~username~~)
Reported by: | pyrog | Owned by: | taylor.smock |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Plugin mapillary | Version: | |
Keywords: | template_report | Cc: |
Description
What steps will reproduce the problem?
- Add Mapillary layer
- Download images
- Display the Mapillary "Image Info" window
What is the expected result?
Display:
- username
- Image detection
- Date
- Id of the image (API v4)
What happens instead?
- username is missing
- Image detection is always 0
- Date/time is not displayed
- Image key (API v3)
Please provide any additional information below. Attach a screenshot if possible.
- https://www.mapillary.com/app/?pKey=780391009330062&lat=45.758536507043&lng=5.697778014083&z=17&focus=photo&trafficSign%5B%5D=regulatory--bicycles-only--g1
- Image key = _P-Al3r4KYhWi-aBxg1vpQ
Revision:17919 Build-Date:2021-06-02 20:30:01 Identification: JOSM/1.5 (17919 en_GB) Mac OS X 11.4 OS Build number: macOS 11.4 (20F71) Memory Usage: 872 MB / 2048 MB (458 MB allocated, but free) Java version: 16.0.1+9, Azul Systems, Inc., OpenJDK 64-Bit Server VM Look and Feel: com.apple.laf.AquaLookAndFeel Screen: Display 69732928 1280×800 (scaling 2.00×2.00) Maximum Screen Size: 1280×800 Best cursor sizes: 16×16→16×16, 32×32→32×32 System property file.encoding: UTF-8 System property sun.jnu.encoding: UTF-8 Locale info: en_GB Numbers with default locale: 1234567890 -> 1234567890 VM arguments: [-Djpackage.app-version=17919, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=/Applications/JOSM.app/Contents/MacOS/JOSM] Dataset consistency test: No problems found Plugins: + Mapillary (2.0.0-alpha.12.3) + SnapNewNodes (1557488602) + apache-commons (35524) + apache-http (35589) + buildings_tools (35756) + cadastre-fr (35758) + ejml (35458) + geotools (35458) + jaxb (35543) + jna (35662) + jts (35458) + opendata (35640) + photo_geotagging (35738) + photoadjust (35770) + scripting (30798) + utilsplugin2 (35691) Tagging presets: + https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml Map paint styles: - ${HOME}/Downloads/Styles_ColourGPSData-style.mapcss Last errors/warnings: - 08389.992 E: java.io.IOException: stream is closed - 08390.643 E: java.io.IOException: stream is closed - 08390.953 E: java.io.IOException: stream is closed - 08391.309 E: java.io.IOException: stream is closed - 08392.508 E: java.io.IOException: stream is closed - 08663.248 E: java.io.IOException: stream is closed - 08663.842 E: java.io.IOException: stream is closed - 08669.521 E: java.io.IOException: stream is closed - 08669.620 E: java.io.IOException: stream is closed - 08670.475 E: java.io.IOException: stream is closed
Attachments (2)
Change History (10)
by , 4 years ago
by , 4 years ago
Attachment: | website.png added |
---|
comment:1 by , 4 years ago
follow-up: 4 comment:3 by , 4 years ago
There is another missing data for API v4 : camera make and model (seen in the Mapillary filter window)
comment:4 by , 4 years ago
Replying to pyrog:
There is another missing data for API v4 : camera make and model (seen in the Mapillary filter window)
Current API docs:
- camera_parameters - FIXME, FIXME
- camera_type - enum, type of camera used for taking the phone. VALUES: FIXME
I'm not touching the camera make/model yet, since it looks like they may be merged (camera_type
), and since they are currently FIXME, they might change.
TBH, I'm currently using an undocumented API which reduces my call volume significantly, but I'd rather not rely on items that might change/get removed right now.
comment:5 by , 4 years ago
The date time issue is fixed in https://github.com/JOSM/Mapillary/releases/tag/v2.0.0-alpha.14.
comment:6 by , 4 years ago
Summary: | Mapillary image info: missing data → Mapillary image info: add additonal information (camera make/model, image detections, ~~username~~) |
---|---|
Type: | defect → enhancement |
comment:7 by , 4 years ago
Summary: | Mapillary image info: add additonal information (camera make/model, image detections, ~~username~~) → Mapillary image info: add additonal information (~~camera make/model~~, image detections, ~~username~~) |
---|
It looks like I won't be able to get camera information.
camera_parameters
and camera_type
returns something like this:
{ "camera_parameters": [0.8444, 0.0001, -1.94e-06], "camera_type": "perspective" }
So it looks like I'm going to be dropping the camera make/model filters. Sorry. I just don't have any way to get that information.
comment:8 by , 4 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
I've fixed image detection counting in c5cff0649505e004bf3cf10e955f2b33ce7ef1f2.
Everything else is cantfix
, unfortunately.
Replying to pyrog:
The v4 API does not give me user information. I'm replacing it with organization information for now.
I've got to make another API call for that. I'm going to skip this for now, as I don't know if I still have an overall rate limit. I do want to bring this back, but it isn't as critical right now. (This would be an additional API call per image, FTR).
I've got a fix for this going in right now (I'm writing the commit message).
The released version is still using the v3 API. I'll release a version today with the v4 API, after I double check that I don't run into API rate limits.