Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21002 closed defect (fixed)

Mapillary plugin: image date/time and author missing

Reported by: richlv Owned by: taylor.smock
Priority: normal Milestone:
Component: Plugin mapillary Version: tested
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Add Mapillary layer
  2. Download images
  3. Enable image window

What is the expected result?

Human-readable image date/time shown in the titlebar, along with the image author (username).

What happens instead?

UNIX timestamp seems to be shown.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-06-02 22:03:39 +0200 (Wed, 02 Jun 2021)
Build-Date:2021-06-02 20:11:30
Revision:17919
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17919 en_GB) Mac OS X 10.15.7
OS Build number: Mac OS X 10.15.7 (19H1217)
Memory Usage: 2093 MB / 3641 MB (1147 MB allocated, but free)
Java version: 1.8.0_291-b10, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 69733382 1680×1050 (scaling 1.00×1.00)
Maximum Screen Size: 1680×1050
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlp.tk=awt, -Djnlpx.jvm=<java.home>/bin/java, -Djnlpx.splashport=-1, -Djnlpx.home=<java.home>/bin, -Djnlpx.remove=false, -Djnlpx.offline=false, -Djnlpx.relaunch=true, -Djnlpx.session.data=/var/folders/nl/flqxqsmj5q963r7tcnfrdt3c0000gn/T/session3154324856755999744, -Djnlpx.heapsize=NULL,NULL, -Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.origFilenameArg=/Users/richlv/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-72e8e992, -Dsun.awt.warmup=true, -Djava.security.manager]
Dataset consistency test: No problems found

Plugins:
+ HouseNumberTaggingTool (35640)
+ InfoMode (35543)
+ Mapillary (2.0.0-alpha.10)
+ PicLayer (1.0.1)
+ apache-commons (35524)
+ apache-http (35589)
+ dataimport (35640)
+ ejml (35458)
+ geotools (35458)
+ imagery_offset_db (35640)
+ javafx-osx (35655)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ measurement (35640)
+ opendata (35640)
+ pbf (35720)
+ photo_geotagging (35738)
+ reverter (35732)
+ utilsplugin2 (35691)

Map paint styles:
+ /Users/richlv/Desktop/ChangeFontSize.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

Last errors/warnings:
- 00081.412 E: Failed to locate image 'void--ground'
- 00081.416 E: Failed to locate image 'void--static'
- 00081.703 E: Failed to locate image 'warning--kangaroo-crossing--g1'
- 12564.559 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 12564.559 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 12564.568 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 12594.588 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 12594.588 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 12594.598 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 12880.927 E: java.util.concurrent.TimeoutException

Attachments (1)

titlebar.png (16.1 KB ) - added by richlv 3 years ago.

Download all attachments as: .zip

Change History (9)

by richlv, 3 years ago

Attachment: titlebar.png added

comment:1 by taylor.smock, 3 years ago

I've been meaning to fix the unix timestamp being shown, but it works right now (tm).

As far as the image author goes, it does not appear that I'll be able to readd that -- the public v4 API ( https://www.mapillary.com/developer/api-documentation ) does not have any author information. The only workaround I'm aware of is to create a new organization, which is returned by the API. I think I modified the window to show the organization instead of the author, prior to seeing the API rate limitations.

I, unfortunately, have bigger fish to fry. Specifically, login with the v4 API, since I hope it will help solve the API rate limitations I hit last week with the v4 API (the rate limit is 200 requests/user/hour, see https://developers.facebook.com/docs/graph-api/overview/rate-limiting ). The only way I have to increase the rate limit for the entire user base is to get login working, and having enough users log in daily/weekly/monthly so that we don't hit the rate limit.

FTR, current requests/user on the v4 API:

  • Tile requests (however many that is, figure 4/hour minimum to account for JOSM overloading tiles)
  • 1 per sequence + number of images in sequence (assuming user goes through all the images), figure minimum 10 calls due to preloading next/previous image information. My contact gave me a non-public API which will (hopefully) reduce this to 2 calls, one for the sequence images, one for all the images in the sequence.
  • 1 per actual image get call (actually, currently 2, but I'll probably not get the thumbnail anymore)

So one user will, at minimum, will use a minimum of 15 calls/hour (I can maybe get this down to 7/hour), if they only look at one image in each sequence.
Without having users log in, that means I can have a maximum of 14 users (29 with 7 requests/hour), if they look at one image each.

I have no clue how many people use the plugin, but probably more than 200 at burst times.

comment:2 by richlv, 3 years ago

Has the username been requested/discussed somewhere?

comment:3 by taylor.smock, 3 years ago

Kind of? https://github.com/JOSM/Mapillary/issues/181

I haven't mentioned the workaround there (creating an organization), but I understand the username removal is a significant issue for many people.
My best guess is that the removal is due to privacy concerns.

in reply to:  3 ; comment:4 by skyper, 3 years ago

Replying to taylor.smock:

My best guess is that the removal is due to privacy concerns.

Well, is the Api public available. Is it better to give the data to one huge company not really caring about privacy?
I guess the rate limiting is a big issue. Are there plans to allow more request by JOSM like some imagery provider do?

in reply to:  4 comment:5 by taylor.smock, 3 years ago

Replying to skyper:

I guess the rate limiting is a big issue. Are there plans to allow more request by JOSM like some imagery provider do?

Hopefully. I've talked with them about it, and they were surprised at the rate limiting as well.
But I am planning on it being 200 requests/user/hour, just so I can work around it, if they aren't able to increase the rate limit.

The 200 requests/user/hour is based off of the daily, weekly, or monthly users, and there is probably some formula where weekly/monthly users is some fraction of those users, i.e., Math.max(daily, weekly fraction, monthly fraction).

I don't even know when the v3 API is getting dropped. For my planning purposes, I'm assuming any day now, while I'm hoping for 6 months for everyone else who uses the v3 API.

comment:6 by taylor.smock, 3 years ago

Ticket #21020 has been marked as a duplicate of this ticket.

comment:7 by taylor.smock, 3 years ago

Resolution: fixed
Status: newclosed

Fixed in https://github.com/JOSM/Mapillary/releases/tag/v2.0.0-alpha.14. At least the date time issue. I cannot fix the user issue.

comment:8 by taylor.smock, 3 years ago

Ticket #21266 has been marked as a duplicate of this ticket.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain taylor.smock.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.