Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21014 closed defect (fixed)

Validator wants end points of weir connected

Reported by: pch14@… Owned by: team
Priority: normal Milestone: 21.06
Component: Core validator Version:
Keywords: template_report weir waterway Cc:

Description

What steps will reproduce the problem?

  1. Map a weir on a river
  2. Close to where a siding parts from it
  3. Hit Validate/Upload

What is the expected result?

Nothing in particular

What happens instead?

Validator claims a missing connection of the weir with the siding waterway

Please provide any additional information below. Attach a screenshot if possible.

Attached .osm file of where I noticed - Initial validation will show two warnings, "Crossing waterway/way" of those might very well be justified, so I just merge the end points of the weir with nodes of the water area. The other warning "Way end node near other way" though remains.

A weir is not a waterway in the sense, the validator message based on?

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-06-02 22:03:39 +0200 (Wed, 02 Jun 2021)
Build-Date:2021-06-02 20:11:30
Revision:17919
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17919 en) Linux Ubuntu 18.04.5 LTS
Memory Usage: 426 MB / 2196 MB (152 MB allocated, but free)
Java version: 1.8.0_181-b13, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1280×1024 (scaling 1.00×1.00)
Maximum Screen Size: 1280×1024
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: C
System property file.encoding: ANSI_X3.4-1968
System property sun.jnu.encoding: ANSI_X3.4-1968
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: XFCE
libcommons-logging-java: libcommons-logging-java:-
fonts-noto: fonts-noto:all-20171026-2
VM arguments: [-Djosm.restart=true, -Djava.net.useSystemProxies=true]
Dataset consistency test: No problems found

Plugins:
+ reltoolbox (35640)
+ reverter (35732)
+ undelete (35640)
+ utilsplugin2 (35691)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/sac_scale&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip

Attachments (1)

BUG-Weir-Ending-Close-To-Other.osm (152.1 KB ) - added by pch14@… 3 years ago.
A weir close to where a siding waterway parts from a river

Download all attachments as: .zip

Change History (5)

by pch14@…, 3 years ago

A weir close to where a siding waterway parts from a river

comment:1 by skyper, 3 years ago

Component: CoreCore validator
Keywords: weir waterway added

comment:2 by mdk, 3 years ago

Similar warning about waterway=dam in #20520.

comment:3 by Klumbumbus, 3 years ago

Resolution: fixed
Status: newclosed

In 17927/josm:

fix #20520, fix #21014 - Don't warn about "End node near other way" for waterway=dam|lock_gate|weir

comment:4 by Klumbumbus, 3 years ago

Milestone: 21.06

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.