#21010 closed enhancement (fixed)
Ask for power poles/towers operator at least in France
Reported by: | francois.lacombe | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | External rule | Version: | |
Keywords: | power, pole, operator | Cc: |
Description
Dear maintainers
National mapping projects about power poles and power towers go well in France since beginning of 2021.
Operator's name is an important information to have when it comes to mapping power supports.
Depending on your interpretation of https://wiki.openstreetmap.org/wiki/Tag:power%3Dpole, is it possible to raise a low level warning when a power=pole or power=tower is edited without operator=* please?
operator=* is recommended.
If it doesn't sound relevant to do so worldwide, is it possible to add it in France only please?
All the best
Attachments (0)
Change History (7)
comment:1 by , 4 years ago
comment:2 by , 4 years ago
Owner: | changed from | to
---|---|
Status: | new → needinfo |
comment:3 by , 4 years ago
Answers:
- Only for power=tower and power=pole currently
- A normal warning is needed: it's intended to encourage French mappers to look for the operator. If we expect them to add a test in their own validator file, 90% of contributors will miss it
- To me, it should be added where power tests are currently, no need to change behavior
comment:4 by , 4 years ago
Owner: | changed from | to
---|---|
Status: | needinfo → new |
Well, all power tests are in java code (PowerLines.java), atm, see #16247, but this test is easily written in mapcss. In my eyes, it does not fit that well in combinations.mapcss and I would not enable it for the whole planet, right now. That is why I thought about a new file for power and similar infrastructure like telecommunication without restriction to France which would make it much easier to disable these test.
Still the easiest solution is to add it to the external french rules and below should work
node[power ~= /^(pole|tower)$/][!operator][inside("FR")] { throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}"); group: tr("missing tag"); }
comment:5 by , 4 years ago
Thank you Skyper for clarification.
According to what you describe, the best option is the French rules file.
I've added a check in revision 62.
I wasn't aware power tests have been moved to a dedicated java file. I'll keep in mind for next time.
Let's close this ticket if it's ok :)
follow-up: 7 comment:6 by , 4 years ago
Component: | Core validator → External rule |
---|---|
Resolution: | → fixed |
Status: | new → closed |
comment:7 by , 4 years ago
Replying to Klumbumbus:
Little fix in https://josm.openstreetmap.de/wiki/Rules/FranceSpecificRules?action=diff&version=64
Thanks
Questions:
pole
or more values likestation
,substation
and[minor_]line
withoutoperator=*
?