Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#20997 closed defect (fixed)

[Validator (FrenchSpecificRules)]: carpool tag does not concern public_transport=stop_area

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: External rule Version:
Keywords: template_report frensh carpool Cc: didier2020, francois.lacombe, PanierAvide, frodrigo

Description

What steps will reproduce the problem?

  1. Create a public_transport=stop_area with name containing the word "covoiturage"
  2. Waiting for osmose analysis
  3. See a osmose alert: "Missing tag carpool on area"

What is the expected result?

No osmose alert.

What happens instead?

Osmose alert.

Please provide any additional information below. Attach a screenshot if possible.

See https://osmose.openstreetmap.fr/fr/issue/65d936e4-2adc-49dc-b7d0-799f0c3fe964

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-06-02 22:03:39 +0200 (Wed, 02 Jun 2021)
Build-Date:2021-06-02 20:11:30
Revision:17919
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17919 fr) Linux Debian GNU/Linux 9.13 (stretch)
Memory Usage: 598 MB / 1755 MB (5 MB allocated, but free)
Java version: 1.8.0_292-8u292-b10-0+deb9u1-b10, Oracle Corporation, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1600×900 (scaling 1.00×1.00)
Maximum Screen Size: 1600×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: fr_FR.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: fr_FR
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: KDE
Java package: openjdk-8-jre:amd64-8u292-b10-0+deb9u1
WebStart package: icedtea-netx:amd64-1.6.2-3.1+deb9u1
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-13+deb9u1
libcommons-logging-java: libcommons-logging-java:all-1.2-1
fonts-noto: fonts-noto:all-20161116-1
VM arguments: [-Dicedtea-web.bin.name=javaws, -Dicedtea-web.bin.location=/usr/bin/javaws, -Djava.security.manager, -Djava.security.policy=/etc/icedtea-web/javaws.policy]
Dataset consistency test: No problems found

Plugins:
+ FixAddresses (35640)
+ apache-commons (35524)
+ cadastre-fr (35758)
+ conflation (0.6.6)
+ ejml (35458)
+ epci-fr (35640)
+ geotools (35458)
+ gson (35458)
+ jaxb (35543)
+ jts (35458)
+ opendata (35640)
+ osm-obj-info (56)
+ pt_assistant (1ff2e15)
+ reverter (35732)
+ scripting (30798)
+ todo (30306)
+ undelete (35640)
+ utilsplugin2 (35691)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Community_Centre&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Historical_Objects&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportOneClick&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/FR.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PoliceFR&zip=1

Map paint styles:
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/FrenchEPCI&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
+ https://josm.openstreetmap.de/josmfile?page=Rules/FranceSpecificRules&zip=1

Last errors/warnings:
- 00021.232 E: Impossible de trouver l'image "bus.png"
- 00021.406 E: <josm.userdata>/plugins/opendata/resources/org/openstreetmap/josm/plugins/opendata/modules/fr/datagouvfr/datasets/agriculture/RegistreParcellaire.mapcss (Aucun fichier ou dossier de ce type)

Attachments (0)

Change History (8)

comment:1 by skyper, 4 years ago

Cc: didier2020 added
Component: CoreExternal rule
Keywords: frensh carpool added

You can fix this by yourself, see Rules/FranceSpecificRules which is editable.

in reply to:  1 comment:2 by anonymous, 4 years ago

Replying to skyper:

You can fix this by yourself, see Rules/FranceSpecificRules which is editable.

I'm not an info. dev., I don't understand the language. I'm only a basic user. #SorryNotSorry

in reply to:  description comment:3 by Klumbumbus, 4 years ago

What steps will reproduce the problem?

  1. See a osmose alert: "Missing tag carpool on area"

I guess thats the intention of the rule!?

comment:4 by Klumbumbus, 4 years ago

Cc: francois.lacombe PanierAvide frodrigo added

comment:5 by PanierAvide, 4 years ago

Fixed : https://josm.openstreetmap.de/wiki/Rules/FranceSpecificRules?action=diff&version=63

I added a condition to only check over amenity=*, which excludes all other kind of feature (including public_transport). Thanks for submitting this issue.

comment:6 by PanierAvide, 4 years ago

Resolution: fixed
Status: newclosed

in reply to:  4 comment:7 by anonymous, 4 years ago

Replying to Klumbumbus:

Not really:a public_transport=stop_area is not a car pooling area (except in case of traffic jams )

in reply to:  6 comment:8 by anonymous, 4 years ago

Replying to PanierAvide:

Thx to you to resolve this issue!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.