Modify

Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#20750 closed enhancement (fixed)

Explain * and ∅ in Layer info window

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 21.04
Component: Core Version:
Keywords: Cc: simon04

Description

The new characters from #12326 should have an explanation. (While * is well-known, ∅ not so much I think.)
I made a patch, please review. It creates no additional i18n string and changes the term "document" to "layer". "document" was a bit strange.

  • OsmDataLayer.java

     
    710710        addConditionalInformation(p, tr("Download is blocked"), data.getDownloadPolicy() == DownloadPolicy.BLOCKED);
    711711        addConditionalInformation(p, tr("Upload is discouraged"), isUploadDiscouraged());
    712712        addConditionalInformation(p, tr("Upload is blocked"), data.getUploadPolicy() == UploadPolicy.BLOCKED);
     713        addConditionalInformation(p, "\u2205 " + tr("Empty layer"), this.getDataSet().isEmpty());
     714        addConditionalInformation(p, "* " + tr("Unsaved changes"), this.isDirty());
    713715
    714716        return p;
    715717    }
     
    12141216        if (isDataSetEmpty() && 1 != GuiHelper.runInEDTAndWaitAndReturn(() ->
    12151217            new ExtendedDialog(
    12161218                    MainApplication.getMainFrame(),
    1217                     tr("Empty document"),
     1219                    tr("Empty layer"),
    12181220                    tr("Save anyway"), tr("Cancel"))
    1219                 .setContent(tr("The document contains no data."))
     1221                .setContent(tr("The layer contains no data."))
    12201222                .setButtonIcons("save", "cancel")
    12211223                .showDialog().getValue()
    12221224        )) {

Attachments (0)

Change History (4)

comment:1 Changed 14 months ago by simon04

Great, thank you!

comment:2 Changed 14 months ago by simon04

Resolution: fixed
Status: newclosed

In 17757/josm:

fix #20750 - Explain * and ∅ in Layer info window (patch by Klumbumbus, modified)

comment:3 Changed 14 months ago by simon04

In 17763/josm:

see #20750 - Fix OsmDataLayerTest

comment:4 Changed 14 months ago by Klumbumbus

Thx.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.