Modify

Opened 4 years ago

Closed 4 years ago

#20570 closed defect (fixed)

[Patch] waterway=riverbank handled differently from natural=water + water=river in validator overlap findings

Reported by: zelonewolf@… Owned by: GerdP
Priority: normal Milestone: 21.03
Component: Core validator Version:
Keywords: overlap Cc:

Description

The attachment has 3 sets of overlapping polygons:

waterway=riverbank / waterway=riverbank
natural=water / waterway=riverbank
natural=water / natural=water

Each of these combinations should report the validator finding "overlapping water areas". Instead:

waterway=riverbank / waterway=riverbank --> reports no findings
natural=water / natural=water --> reports 2 findings, overlapping identical natural areas/water areas
natural=water / waterway=riverbank --> reports crossing waterway/way finding

It appears that waterway=riverbank is not being treated as a water area.
In addition, it seems that we should exclude natural=water from the "overlapping identical natural areas" finding, since that is duplicated by the "identical water areas finding"

Attachments (2)

riverbank_water_issues.osm (3.9 KB ) - added by zelonewolf@… 4 years ago.
Test case demonstrating the problem.
20570.patch (1.4 KB ) - added by GerdP 4 years ago.

Download all attachments as: .zip

Change History (5)

by zelonewolf@…, 4 years ago

Attachment: riverbank_water_issues.osm added

Test case demonstrating the problem.

by GerdP, 4 years ago

Attachment: 20570.patch added

comment:1 by GerdP, 4 years ago

Milestone: 21.03
Owner: changed from team to GerdP
Status: newassigned
Summary: waterway=riverbank handled differently from natural=water + water=river in validator overlap findings[Patch] waterway=riverbank handled differently from natural=water + water=river in validator overlap findings

The patch fixes these issues.

comment:2 by skyper, 4 years ago

Component: CoreCore validator
Keywords: overlap added

comment:3 by GerdP, 4 years ago

Resolution: fixed
Status: assignedclosed

In 17629/josm:

fix #20570: waterway=riverbank handled differently from natural=water + water=river in validator overlap findings

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.