Opened 4 years ago
Closed 4 years ago
#20570 closed defect (fixed)
[Patch] waterway=riverbank handled differently from natural=water + water=river in validator overlap findings
| Reported by: | Owned by: | GerdP | |
|---|---|---|---|
| Priority: | normal | Milestone: | 21.03 |
| Component: | Core validator | Version: | |
| Keywords: | overlap | Cc: |
Description ¶
The attachment has 3 sets of overlapping polygons:
waterway=riverbank / waterway=riverbank
natural=water / waterway=riverbank
natural=water / natural=water
Each of these combinations should report the validator finding "overlapping water areas". Instead:
waterway=riverbank / waterway=riverbank --> reports no findings
natural=water / natural=water --> reports 2 findings, overlapping identical natural areas/water areas
natural=water / waterway=riverbank --> reports crossing waterway/way finding
It appears that waterway=riverbank is not being treated as a water area.
In addition, it seems that we should exclude natural=water from the "overlapping identical natural areas" finding, since that is duplicated by the "identical water areas finding"
Change History (5)
by , 4 years ago
| Attachment: | riverbank_water_issues.osm added |
|---|
by , 4 years ago
| Attachment: | 20570.patch added |
|---|
comment:1 by , 4 years ago
| Milestone: | → 21.03 |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
| Summary: | waterway=riverbank handled differently from natural=water + water=river in validator overlap findings → [Patch] waterway=riverbank handled differently from natural=water + water=river in validator overlap findings |
The patch fixes these issues.
comment:2 by , 4 years ago
| Component: | Core → Core validator |
|---|---|
| Keywords: | overlap added |
Test case demonstrating the problem.