Opened 3 years ago

Closed 3 years ago

#20535 closed enhancement (fixed)

URL entry fields should automatically remove leading/trailing spaces or newlines

Reported by: Sinus Pi Owned by: Don-vip
Priority: normal Milestone: 21.02
Component: Core imagery Version:
Keywords: template_report Cc:


What steps will reproduce the problem?

  1. Paste an URL with leading or trailing spaces or newlines into the GetCapabilities url field (2)
  2. Hit (3)
  3. See an error

What is the expected result?

The URL should be sanitized to remove whitespace

What happens instead?

JOSM tries to use the URL as-is, with whitespace

Please provide any additional information below. Attach a screenshot if possible.

Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-12-28 22:03:23 +0100 (Mon, 28 Dec 2020)
Build-Date:2020-12-30 02:30:55
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17428 pl) Windows 10 64-Bit
OS Build number: Windows 10 Home 1909 (18363)
Memory Usage: 813 MB / 1820 MB (416 MB allocated, but free)
Java version: 1.8.0_271-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel:
Screen: \Display0 1920×1080 (scaling 1,00×1,00) \Display1 1680×1050 (scaling 1,00×1,00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
VM arguments: [,<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\Downloads\josm.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=19684, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

+ PicLayer (2a9aa7a)
+ apache-commons (35524)
+ areaselector (368)
+ austriaaddresshelper (1597341117)
+ buildings_tools (35669)
+ ejml (35458)
+ geotools (35458)
+ jaxb (35543)
+ jts (35458)
+ log4j (35458)
+ opendata (35640)
+ utilsplugin2 (35691)

Map paint styles:
+ C:\DOKUMENTY\elemstyles.mapcss

Last errors/warnings:
- 00236,375 E: Could not parse WMS layer list. Incoming data:
- 02145,609 E: java.nio.file.InvalidPathException: Illegal char <:> at index 5: https:\\cgi-bin\KrajowaIntegracjaEwidencjiGruntow?SERVICE=WMS&REQUEST=GetCapabilities&language=pol

Attachments (0)

Change History (3)

comment:1 by Don-vip, 3 years ago

Component: CoreCore imagery

comment:2 by Don-vip, 3 years ago

Milestone: 21.02
Owner: changed from team to Don-vip
Status: newassigned

comment:3 by Don-vip, 3 years ago

Resolution: fixed
Status: assignedclosed

In 17543/josm:

fix #20535 - strip leading/trailing whitespace from URLs entered in "Add WMS/WMTS" dialogs

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.