Modify

#20519 closed defect (fixed)

NPE in Upload Dialog

Reported by: GerdP Owned by: Don-vip
Priority: blocker Milestone: 21.02
Component: Core Version: latest
Keywords: template_report Cc: Don-vip

Description

What steps will reproduce the problem?

  1. No idea. The only special thing I did in this session was to play with options regarding the drawing of GPX tracks, searching for a way to colour the track using the recorded elevation data

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Revision:17522
Is-Local-Build:true
Build-Date:2021-02-22 08:43:23

Identification: JOSM/1.5 (17522 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 1044 MB / 1972 MB (138 MB allocated, but free)
Java version: 15.0.1+9, AdoptOpenJDK, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1,00×1,00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (35669)
+ o5m (35640)
+ pbf (35708)
+ poly (35640)
+ reltoolbox (35640)
+ reverter (35688)
+ undelete (35640)
+ utilsplugin2 (35691)

Validator rules:
+ c:\josm\core\resources\data\validator\geometry.mapcss

Last errors/warnings:
- 00000,496 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000,498 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00985,116 W: Conflicts detected - <html>There were 8 conflicts detected.</html>
- 01068,032 E: java.lang.IllegalStateException: JOSM expected to find primitive [way -103747] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 01261,226 E: java.lang.IllegalStateException: JOSM expected to find primitive [way -104336] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 07992,028 W: java.io.IOException: Tags to paste are not valid.
- 10878,844 E: Handled by bug report queue: java.lang.NullPointerException: Cannot invoke "String.length()" because "str" is null



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (21) of main
java.lang.NullPointerException: Cannot invoke "String.length()" because "str" is null
	at java.base/java.lang.AbstractStringBuilder.<init>(AbstractStringBuilder.java:105)
	at java.base/java.lang.StringBuilder.<init>(StringBuilder.java:125)
	at org.openstreetmap.josm.gui.io.UploadDialog.getCommentWithDataSetHashTag(UploadDialog.java:349)
	at org.openstreetmap.josm.gui.io.UploadDialog.setChangesetTags(UploadDialog.java:302)
	at org.openstreetmap.josm.gui.io.UploadDialog.setChangesetTags(UploadDialog.java:281)
	at org.openstreetmap.josm.actions.UploadAction.uploadData(UploadAction.java:242)
	at org.openstreetmap.josm.actions.UploadAction.actionPerformed(UploadAction.java:292)
	at java.desktop/javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1810)
	at java.desktop/javax.swing.JComponent.processKeyBinding(JComponent.java:2900)
	at java.desktop/javax.swing.KeyboardManager.fireBinding(KeyboardManager.java:311)
	at java.desktop/javax.swing.KeyboardManager.fireKeyboardAction(KeyboardManager.java:266)
	at java.desktop/javax.swing.JComponent.processKeyBindingsForAllComponents(JComponent.java:2993)
	at java.desktop/javax.swing.JComponent.processKeyBindings(JComponent.java:2985)
	at java.desktop/javax.swing.JComponent.processKeyEvent(JComponent.java:2862)
	at java.desktop/java.awt.Component.processEvent(Component.java:6391)
	at java.desktop/java.awt.Container.processEvent(Container.java:2263)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4990)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4822)
	at java.desktop/java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1950)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:870)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1139)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:1009)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:835)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4871)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2769)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4822)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

Attachments (0)

Change History (7)

comment:1 Changed 11 months ago by GerdP

Ah, sorry, I also used Purge in this session: Changed a way completely and did more changes, later I decided to purge the changes on way and reloaded it. Got eight conflicts, selected them all and used "resolve to their versions".

comment:2 Changed 11 months ago by GerdP

OK, Ive saved the session as a *.joz file (and also the preferences.xml), closed JOSM and started it again and loaded the *.joz file. Same NPE.
Same problem when I start JOSM again and just try to upload a new node.
Tried also with a backup of preferences.xml and still see the same NPE.

comment:3 Changed 11 months ago by GerdP

Cc: Don-vip added

Ah, it's a regression of r17521.

comment:4 Changed 11 months ago by GerdP

Priority: normalblocker
Version: latest

comment:5 Changed 11 months ago by Don-vip

Milestone: 21.02
Owner: changed from team to Don-vip
Status: newassigned

comment:6 Changed 11 months ago by GerdP

I was able to upload my changes with tested (17428). getCommentWithDataSetHashTag() must cope with comment being null.

comment:7 Changed 11 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 17523/josm:

fix #20519 - NPE in Upload Dialog

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.