Modify

Opened 16 months ago

Closed 13 months ago

Last modified 13 months ago

#20450 closed defect (fixed)

[Patch] "Paved or heavily compacted hardcore surface" vs "Solid. Usually a paved or sealed surface." for tracktype=grade1

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 21.04
Component: Internal preset Version:
Keywords: template_report Cc:

Description (last modified by mkoniecz)

What steps will reproduce the problem?

  1. Tag highway=track tracktype=grade1 on way
  2. Press tractor icon over tag list
  3. Press tractype dropdown

What is the expected result?

Description matches https://wiki.openstreetmap.org/wiki/Key:tracktype

What happens instead?

It is not.

Please provide any additional information below. Attach a screenshot if possible.

Wiki is not some new change - see proposal from 2007 https://wiki.openstreetmap.org/wiki/Proposed_features/grade1-5 "A track that is concreted or tarmacked" or wiki history - state in 2014 has current wording ( https://wiki.openstreetmap.org/w/index.php?title=Key:tracktype&oldid=1058510 )

Overall I think that JOSM version misleadingly describes tracktype=grade1 as acceptable for surface=compacted

Osmose complains about tracktype=grade1 surface=compacted that is not a problem according to JOSM definition.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-01-21 23:33:21 +0100 (Thu, 21 Jan 2021)
Revision:17474
Build-Date:2021-01-22 02:30:49
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17474 en) Linux Ubuntu 20.04.2 LTS
Memory Usage: 534 MB / 3974 MB (232 MB allocated, but free)
Java version: 11.0.9.1+1-Ubuntu-0ubuntu1.20.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Desktop environment: LXQt
Java package: openjdk-11-jre:amd64-11.0.9.1+1-0ubuntu1~20.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
Environment variable LANG: en_US.UTF-8
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (35669)
+ reverter (35688)
+ todo (30306)

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
+ ${HOME}/Documents/install_moje/OSM software/manual editing and discussions/josm/resources/data/validator/deprecated.mapcss

Last errors/warnings:
- 00017.685 E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<The maximum bbox size is 0.25, and your request was too large. Either request a smaller area, or use planet.osm>
- 00017.701 E: Bad Request - <html>The OSM server 'api.openstreetmap.org' reported a bad request.<br><br>The area you tried to download is too big or your request was too large.<br>Either request a smaller area or use an export file provided by the OSM community.</html>
- 00043.075 E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<The maximum bbox size is 0.25, and your request was too large. Either request a smaller area, or use planet.osm>
- 00043.080 E: Bad Request - <html>The OSM server 'api.openstreetmap.org' reported a bad request.<br><br>The area you tried to download is too big or your request was too large.<br>Either request a smaller area or use an export file provided by the OSM community.</html>

Attachments (2)

josm_20450_tracktype.patch (2.2 KB) - added by skyper 13 months ago.
patch using the description from the Map Feature template
josm_20450_tracktype_v2.patch (2.3 KB) - added by skyper 13 months ago.
fixed grade4

Download all attachments as: .zip

Change History (10)

comment:1 Changed 16 months ago by mkoniecz

Description: modified (diff)

Changed 13 months ago by skyper

Attachment: josm_20450_tracktype.patch added

patch using the description from the Map Feature template

comment:2 Changed 13 months ago by skyper

Summary: "Paved or heavily compacted hardcore surface" vs "Solid. Usually a paved or sealed surface." for tracktype=grade1[Patch] "Paved or heavily compacted hardcore surface" vs "Solid. Usually a paved or sealed surface." for tracktype=grade1

Find attached patch which uses the description from the wiki.

Last edited 13 months ago by skyper (previous) (diff)

comment:3 Changed 13 months ago by Klumbumbus

What exaclty do you mean with "Map Feature template"? I don't see tracktype descriptions on https://wiki.openstreetmap.org/wiki/Map_features or https://wiki.openstreetmap.org/wiki/Template:Map_Features:highway. Instead it links to https://wiki.openstreetmap.org/wiki/Key:tracktype where grade4 is a little different from you patch.

comment:4 Changed 13 months ago by Klumbumbus

Milestone: 21.04

Changed 13 months ago by skyper

fixed grade4

comment:5 Changed 13 months ago by skyper

I was talking about Template:Map_Features:highway and should look twice at my work that late, sorry. I have attached version 2.

comment:6 Changed 13 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 17819/josm:

fix #20450 - Sync tracktype=* descriptions with OSM wiki (patch by skyper)

comment:7 Changed 13 months ago by anonymous

Is it going to also invalidate existing translations?

comment:8 in reply to:  7 Changed 13 months ago by Klumbumbus

Replying to anonym:

Is it going to also invalidate existing translations?

Yes.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.