Remove pointless duplicates of motor_vehicle=no

[mkoniecz]

What steps will reproduce the problem? ¶

1. Validate ​https://www.openstreetmap.org/way/332027561/history

What is the expected result? ¶

Validator asks to remove pointless tags

What happens instead? ¶

There were some presets that encouraged adding every single possible tag. It ends with some bizarre cases of useless tag soup. See say ​https://www.openstreetmap.org/way/332027561/history

with motor_vehicle=no - is it actually useful to have also:

goods=no, hgv=no, hov=no, motorcar=no, motorcycle=no, psv=no, tourist_bus=no?

Please provide any additional information below. Attach a screenshot if possible. ¶

I encountered it while preparing to implement #10003 - I discovered hov=no

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-01-21 23:33:21 +0100 (Thu, 21 Jan 2021)
Revision:17474
Build-Date:2021-01-22 02:30:49
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17474 en) Linux Ubuntu 20.04.1 LTS
Memory Usage: 509 MB / 3974 MB (299 MB allocated, but free)
Java version: 11.0.9.1+1-Ubuntu-0ubuntu1.20.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Desktop environment: LXQt
Java package: openjdk-11-jre:amd64-11.0.9.1+1-0ubuntu1~20.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
Environment variable LANG: en_US.UTF-8
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ reverter (35688)
+ todo (30306)

[gaben]

is it actually useful to have also goods=no, hgv=no, hov=no, motorcar=no, motorcycle=no, psv=no, tourist_bus=no?

Probably not. Codewise a MapCSS rule would be enough.

If someone is willing to commit (=agrees with the idea), I can create a patch.

[skyper]

Well,we have some discussions about setting resp. removing defaults values but I think it makes no sense in this case to repeat all the subclasses.
There are more tags like lhv=no, bus=no and taxi=no which could be added.
How about vehicle=no with even more possible subclasses?

[gaben]

I have an idea, probably overkill: implement the whole access hierarchy either in MapCSS or Java, then run a root to leaf check. If the parent is already set to false (e.g. vehicle), remove any leafs which has false value (e.g. car). Not sure if it would be internationally universal due to minor differences.