Modify

Opened 7 years ago

Last modified 5 weeks ago

#10003 new enhancement

Convert access=hov to access=no + hov=yes [PATCH]

Reported by: mkoniecz Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: Cc:

Description (last modified by mkoniecz)

access=hov appears 2 124 times, hov=* appears 11 293 times (http://taginfo.openstreetmap.org/keys/access#values http://taginfo.openstreetmap.org/keys/hov).

According to access wiki page "Use the access=* key to describe a general access restriction that applies to all transport modes.". As result, it impossible to guess meaning of say access=hov + foot=yes.

Other access values that should be tagged as combination of access=no + something=yes: emergency (1 347 directly in access vs 33 070 as a proper separate key), psv (1 125 directly in access vs 61 375 as a proper separate key).

agricultural and forestry are far less likely to appear on roads with complex tagging, also special value in access seems here to be more popular than a separate key (100 881 vs 28 548, 24 831 vs 3 196) but I would suggest changing it also here.

Note that access=agricultural, access=forestry appear in JOSM presets. access=psv, emergency, hov does not appear.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-05-11 01:36:45
Last Changed Author: bastiK
Revision: 7105
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-05-11 01:48:28 +0200 (Sun, 11 May 2014)
Last Changed Rev: 7105

Identification: JOSM/1.5 (7105 en) Windows 7 32-Bit
Memory Usage: 78 MB / 494 MB (20 MB allocated, but free)
Java version: 1.7.0_55, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Xmx512M]
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (30416)
Plugin: RoadSigns (30438)
Plugin: buildings_tools (30416)
Plugin: continuosDownload (28565)
Plugin: lakewalker (30416)
Plugin: measurement (30416)
Plugin: notes (v0.9.2)
Plugin: wikipedia (30416)

Attachments (0)

Change History (11)

comment:1 Changed 7 years ago by mkoniecz

Description: modified (diff)

comment:2 Changed 7 years ago by mkoniecz

Description: modified (diff)

comment:3 Changed 7 years ago by mkoniecz

Description: modified (diff)

comment:4 Changed 7 years ago by mkoniecz

Description: modified (diff)

comment:5 Changed 7 years ago by mkoniecz

Description: modified (diff)

comment:6 Changed 7 years ago by mkoniecz

Description: modified (diff)

comment:7 Changed 2 years ago by mkoniecz

access=hov appears 1 187 times so I still think that it is worth adding.

comment:8 Changed 9 months ago by skyper

+1 for warnings about hov, psv and emergency in values, e.g. vehicle=psv is also discouraged.

comment:9 Changed 5 weeks ago by mkoniecz

  • resources/data/validator/deprecated.mapcss

    diff --git i/resources/data/validator/deprecated.mapcss w/resources/data/validator/deprecated.mapcss
    index e5420bad8..25c479815 100644
    i w way[shoulder=none] { 
    22552255  fixChangeKey: "amenity => diplomatic";
    22562256}
    22572257
     2258/* #10003 */
     2259*[access=hov] {
     2260  throwWarning: tr("{0} is deprecated", "{0.tag}");
     2261  suggestAlternative: "access=no hov=yes";
     2262  group: tr("deprecated tagging");
     2263  fixAdd: "access=no";
     2264  fixAdd: "hov=yes";
     2265}
     2266
    22582267/* When tags are deprecated they should be added to ignoretags.cfg too. */
/* #10003 */
*[access=hov] {
  throwWarning: tr("{0} is deprecated", "{0.tag}");
  suggestAlternative: "access=no hov=yes";
  group: tr("deprecated tagging");
  fixAdd: "access=no";
  fixAdd: "hov=yes";
}

Please let me know if you prefer a different patch format.

Hopefully this is still considered as a valid.

Last edited 5 weeks ago by skyper (previous) (diff)

comment:10 Changed 5 weeks ago by mkoniecz

Summary: Convert access=hov to access=no + hov=yesConvert access=hov to access=no + hov=yes [PATCH]

comment:11 Changed 5 weeks ago by skyper

I do not like the auto fix as I can imagine problems with access=no. Often only (motor_)vehicle=no is needed and even then you need to check the other access tags.

* #10003 */
node[barrier][JOSM_search("*=emergency OR *=hov OR *=psv")],
way[highway][JOSM_search("*=emergency OR *=hov OR *=psv")],
relation[highway][JOSM_search("*=emergency OR *=hov OR *=psv")] {
  throwWarning: tr("{0}, {1} and {2} are deprecated as values", "emergency", "hov", "psv";
  group: tr("deprecated tagging");
}

I struggled to find a test for :lanes-tagging like vehicle:lanes:forward=yes|yes|hov.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to mkoniecz
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.