Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#20355 closed enhancement (fixed)

Distributed Snap package uses old JOSM app icon

Reported by: gaben Owned by: mvogt
Priority: normal Milestone:
Component: unspecified Version:
Keywords: linux snap Cc: mvogt

Description (last modified by gaben)

On Ubuntu, if I search for JOSM, I get two different versions listed in the Ubuntu Software Center. One is from the Ubuntu universe other from Snap store. They differ in many things, but the most eye-catcher is the icon. Is it intended?

screenshot

I also see that the snapcraft.yml in JOSM source not using best practices (maybe the smaller than recommended icon size is the most prominent).

Attachments (1)

Ubuntu_store.png (26.4 KB ) - added by gaben 5 years ago.
screenshot

Download all attachments as: .zip

Change History (7)

by gaben, 5 years ago

Attachment: Ubuntu_store.png added

screenshot

comment:1 by gaben, 5 years ago

Description: modified (diff)

comment:2 by mvogt, 5 years ago

Owner: changed from team to mvogt

Thanks for your bugreport. I will update the icon for the snap.

Fwiw, the snap is build from https://github.com/mvo5/josm-snapcraft and the version inside the svn repo is not current anymore. Mostly because auto-building from svn is not supported by the snapcraft machinery (last I looked at least).

comment:3 by mvogt, 5 years ago

I updated the icon and it will be part of the next build from build.snapcraft.io

comment:4 by mvogt, 5 years ago

Resolution: fixed
Status: newclosed

The updated snap is now released to stable so this should be fixed now. Please reopen if I missed anything.

in reply to:  2 comment:5 by gaben, 5 years ago

Replying to mvogt:

Fwiw, the snap is build from https://github.com/mvo5/josm-snapcraft and the version inside the svn repo is not current anymore. Mostly because auto-building from svn is not supported by the snapcraft machinery (last I looked at least).

If it's not needed and out of date, should the dev team delete the file from the svn repo?

comment:6 by mvogt, 5 years ago

Removing the snapcraft.yaml from the svn repo is fine. I had hoped that eventually either the launchpad autobuilding from svn gets fixed or that the repo moves to git and then having it would become very useful again. But until either happens it's fine to remove it. Launchpad allows building automatically if the repo changes to the "edge" snap channel which I find super useful to track progress/test new features etc. But as outlined above it will not work currently in this particular repor unfortunately.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain mvogt.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.