Modify

Opened 4 years ago

Closed 4 years ago

#20323 closed defect (duplicate)

Purge + Update data + Undo : gives an error

Reported by: leni Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report purge command stack undo Cc:

Description

What steps will reproduce the problem?

  1. I open a recent file: File/Open Recent/*.osm
  2. I Purge half part of the layer
  3. I Update data the purge, the server data of the area purged reappears
  4. Undo

What is the expected result?

if the undo from a purge is not possible, block the undo

What happens instead?

An unexpected exception

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-11-21 14:56:29 +0100 (Sat, 21 Nov 2020)
Build-Date:2020-11-22 02:30:52
Revision:17329
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17329 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19042)
Memory Usage: 244 MB / 247 MB (119 MB allocated, but free)
Java version: 1.8.0_271-b09, Oracle Corporation, Java HotSpot(TM) Client VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.30)
+ apache-commons (35524)
+ apache-http (35589)
+ contourmerge (v0.1.6)
+ ejml (35458)
+ flatlaf (35652)
+ geotools (35458)
+ imagery_offset_db (35640)
+ indoorhelper (eca65b2)
+ javafx-windows (35655)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ measurement (35640)
+ opendata (35640)
+ photo_geotagging (35640)
+ photoadjust (35640)
+ reverter (35640)
+ scripting (30798)
+ shrinkwrap (v1.0.4)
+ tageditor (35640)
+ todo (30306)
+ utilsplugin2 (35674)
+ wikipedia (1.1.4)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- <josm.pref>\styles\sit.mapcss
+ <josm.pref>\styles\sit.mapcss

Validator rules:
+ https://raw.githubusercontent.com/nlehuby/transport_mapcss/master/transport.validator.mapcss

Last errors/warnings:
- 00068.187 E: Failed to locate image 'regulatory--dual-lanes-cyclists-and-pedestrians--g1'
- 00069.179 E: Failed to locate image 'regulatory--texts--g1'
- 00069.180 E: Failed to locate image 'regulatory--texts--g2'
- 00069.355 E: Failed to locate image 'void--car-mount'
- 00069.356 E: Failed to locate image 'void--dynamic'
- 00069.357 E: Failed to locate image 'void--ego-vehicle'
- 00069.358 E: Failed to locate image 'void--ground'
- 00069.359 E: Failed to locate image 'void--static'
- 00069.604 E: Failed to locate image 'warning--kangaroo-crossing--g1'
- 00205.264 E: Handled by bug report queue: java.lang.AssertionError: Primitive {Node id=4450280791 version=1 VT lat=43.6558428,lon=1.3790606} was removed when purging, but is still there on undo


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (15) of main
java.lang.AssertionError: Primitive {Node id=4450280791 version=1 VT lat=43.6558428,lon=1.3790606} was removed when purging, but is still there on undo
	at org.openstreetmap.josm.command.PurgeCommand.lambda$undoCommand$1(PurgeCommand.java:136)
	at org.openstreetmap.josm.data.osm.DataSet.update(DataSet.java:961)
	at org.openstreetmap.josm.command.PurgeCommand.undoCommand(PurgeCommand.java:126)
	at org.openstreetmap.josm.data.UndoRedoHandler.lambda$undo$0(UndoRedoHandler.java:380)
	at org.openstreetmap.josm.gui.util.GuiHelper.runInEDTAndWait(GuiHelper.java:224)
	at org.openstreetmap.josm.data.UndoRedoHandler.undo(UndoRedoHandler.java:372)
	at org.openstreetmap.josm.data.UndoRedoHandler.undo(UndoRedoHandler.java:362)
	at org.openstreetmap.josm.actions.UndoAction.actionPerformed(UndoAction.java:39)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

Change History (1)

comment:1 by skyper, 4 years ago

Keywords: purge command stack undo added
Resolution: duplicate
Status: newclosed

Closed as duplicate of #19331.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.