Circle arc: New nodes only added after last middle node with several parents

[skyper]

What steps will reproduce the problem?

1. Have a slightly bent way with several child nodes including some middle nodes with more ways as parents
   • Please use the way (id:219043378) in example.osm.bz2​ from #10205.
2. Circle arc

What is the expected result?

In this special case at least a notification about moving nodes outside downloaded area.
The way nodes are moved to form a circle arc and new nodes are inserted if the segment is too long and nodes are nicely distributed respecting nodes with multiple parents and/or tags.

What happens instead?

No notification about possible move of nodes outside download area.
New nodes are only inserted after the last middle node with several parents but not before that node.

Please provide any additional information below. Attach a screenshot if possible.

Sorry, but I am not sure when this problem was introduced.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-12-01 20:59:49 +0100 (Tue, 01 Dec 2020)
Revision:17383
Build-Date:2020-12-02 02:30:51
URL:https://josm.openstreetmap.de/svn/trunk

Plugins:
+ utilsplugin2 (35640)

[skyper]

I seems a node which is off the virtual arc triggers also this behavior, as the node is not moved and new nodes are only added after this node.

[taylor.smock]

@skyper: Is this still a problem? I was unable to reproduce.

[skyper]

Well, it looks like there are no nodes moved outside download area but the general problem of only using the last part of the way persist.
In fact, it does not depend on the number of parents. Only the last two segments of the way are used. Just reverse the direction of the way in advance of using circle arc. In my opinion the result should be the same and the whole way and not only segments of it should be curved.

[taylor.smock]

In my opinion the result should be the same and the whole way and not only segments of it should be curved.

In this case, we are probably going to want to make it configurable somehow -- when I map sidewalks, I often take advantage of the fact that it only curves the last two segments.

[skyper]

Replying to taylor.smock:

In my opinion the result should be the same and the whole way and not only segments of it should be curved.

In this case, we are probably going to want to make it configurable somehow -- when I map sidewalks, I often take advantage of the fact that it only curves the last two segments.

Oh, sorry, I just reread the documentation (Help/Action/CreateCircleArc) and I was wrong. I need to select the way and three nodes to get my expected result.

Though this way, nodes outside download area are moved without a notification.

[GerdP]

Though this way, nodes outside download area are moved without a notification.

This happens when you select e.g. nodes 4, 5, and 7 and the way and node 6 is outside. In that case node 6 may is moved without a warning.