Modify

Opened 5 weeks ago

Closed 5 weeks ago

Last modified 8 days ago

#19993 closed defect (fixed)

newlines in notes should be shown as spaces

Reported by: mnalis Owned by: Don-vip
Priority: normal Milestone: 20.11
Component: Core notes Version: tested
Keywords: template_report Cc:

Description (last modified by Don-vip)

What steps will reproduce the problem?

  1. open notes window
  2. navigate to part of map with multi-line notes (like the ones created by StreetComplete)
  3. download notes
  4. observe multiline text squashed together without spaces in notes window

What is the expected result?

The notes shown should have space or ";" or some other delimeter where there was newline, for example
"yamaha, 53 via StreetComplete 24.0 Attached Photos: ..."
or even better:
"yamaha, 53; via StreetComplete 24.0; Attached Photos: ..."

What happens instead?

newlines are completely ignored, so text looks like:
"yamaha, 53via StreetComplete 24.0Attached Photos: ..."

Please provide any additional information below. Attach a screenshot if possible.

Notes window eats newlines, but in details newlines are shown OK.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-10-03 13:42:38 +0200 (Sat, 03 Oct 2020)
Revision:17084
Build-Date:2020-10-04 01:30:47
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17084 en) Linux Debian GNU/Linux 10 (buster)
Memory Usage: 743 MB / 2048 MB (166 MB allocated, but free)
Java version: 11.0.8+10-post-Debian-1deb10u1, Debian, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32
Desktop environment: ICEWM
VM arguments: [--patch-module=java.desktop=/usr/share/icedtea-web/netx.jar:, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,jdk.jsobject, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, -Dicedtea-web.bin.name=javaws, -Dicedtea-web.bin.location=/usr/share/icedtea-web/bin/javaws.sh, -Djava.security.manager, -Djava.security.policy=/etc/icedtea-web/javaws.policy]
Dataset consistency test: No problems found

Plugins:
+ DirectDownload (35552)
+ DirectUpload (35550)
+ FixAddresses (35343)
+ PicLayer (35405)
+ apache-commons (35524)
+ apache-http (35092)
+ buildings_tools (35570)
+ conflation (0.6.6)
+ geochat (35405)
+ imagery_offset_db (35405)
+ jna (35092)
+ jts (35122)
+ measurement (35405)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ reverter (35556)
+ turnlanes (35405)
+ turnrestrictions (35515)
+ utilsplugin2 (35487)

Tagging presets:
+ https://<user.name>.com/prezentacije/OpenStreetMap/josm-preset.xml

Map paint styles:
- /tmp/elemstyles.mapcss
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1
- https://raw.githubusercontent.com/OpenSeaMap/josm/master/CEVNI_MapCSS.mapcss
+ http://bezdomni.net/Styles_HighlightedCapesBays-style.mapcss 

Last errors/warnings:
- 02538.339 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = osm-hr_ Zagreb 2018 Aerial imagery:https://tms.osm-hr.org/zagreb-2018/{zoom}/{x}/{-y}.png/17/71304/46732
- 02538.413 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = osm-hr_ Zagreb 2018 Aerial imagery:https://tms.osm-hr.org/zagreb-2018/{zoom}/{x}/{-y}.png/16/35652/23366
- 02538.414 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = osm-hr_ Zagreb 2018 Aerial imagery:https://tms.osm-hr.org/zagreb-2018/{zoom}/{x}/{-y}.png/15/17826/11683
- 02538.414 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = osm-hr_ Zagreb 2018 Aerial imagery:https://tms.osm-hr.org/zagreb-2018/{zoom}/{x}/{-y}.png/14/8913/5841
- 02538.439 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = osm-hr_ Zagreb 2018 Aerial imagery:https://tms.osm-hr.org/zagreb-2018/{zoom}/{x}/{-y}.png/13/4456/2920
- 02762.644 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = osm-hr_ Zagreb 2018 Aerial imagery:https://tms.osm-hr.org/zagreb-2018/{zoom}/{x}/{-y}.png/18/142607/93463
- 02762.645 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = osm-hr_ Zagreb 2018 Aerial imagery:https://tms.osm-hr.org/zagreb-2018/{zoom}/{x}/{-y}.png/16/35651/23365
- 02762.645 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = osm-hr_ Zagreb 2018 Aerial imagery:https://tms.osm-hr.org/zagreb-2018/{zoom}/{x}/{-y}.png/15/17825/11682
- 02762.646 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = osm-hr_ Zagreb 2018 Aerial imagery:https://tms.osm-hr.org/zagreb-2018/{zoom}/{x}/{-y}.png/17/71303/46731
- 02762.704 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = osm-hr_ Zagreb 2018 Aerial imagery:https://tms.osm-hr.org/zagreb-2018/{zoom}/{x}/{-y}.png/14/8912/5841

Attachments (1)

notes-multiline.png (1.7 MB) - added by mnalis 5 weeks ago.
Notes window eats newlines, but in details newlines are shown OK.

Download all attachments as: .zip

Change History (5)

Changed 5 weeks ago by mnalis

Attachment: notes-multiline.png added

Notes window eats newlines, but in details newlines are shown OK.

comment:1 Changed 5 weeks ago by Don-vip

Description: modified (diff)

comment:2 Changed 5 weeks ago by Don-vip

Description: modified (diff)
Milestone: 20.10
Owner: changed from team to Don-vip
Status: newassigned

comment:3 Changed 5 weeks ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 17269/josm:

fix #19993 - handle multiline note comments in notes dialog

comment:4 Changed 8 days ago by Don-vip

Milestone: 20.1020.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.