Modify

Opened 3 years ago

Closed 2 years ago

#19984 closed defect (duplicate)

[RFC] [Patch] Changeset manager shows wrong data after sorting

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report regression Cc: Don-vip

Description (last modified by GerdP)

What steps will reproduce the problem?

  1. Open Changeset manager
  2. click "My changesets"
  3. select a row and verify that the data shown in the lower panels matches the selected row
  4. sort by number of changes descending (or maybe ID or Comment)
  5. note that the content of the panels is no longer matches the selected rows

What is the expected result?

data should match

What happens instead?

see 5.

Please provide any additional information below. Attach a screenshot if possible.


When sorting by "Closed at" the data matches again.
Regression of r16826

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-10-03 13:42:38 +0200 (Sat, 03 Oct 2020)
Build-Date:2020-10-04 01:30:47
Revision:17084
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17084 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 979 MB / 3641 MB (386 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
VM arguments: [-XX:StartFlightRecording=name=MyRecording2,settings=d:\dbg\gerd.jfc, -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true,dumponexitpath=e:\ld\perf_20201022_114536.jfr]

Plugins:
+ OpeningHoursEditor (35579)
+ PolygonCutOut (v0.7)
+ apache-commons (35524)
+ buildings_tools (35579)
+ conflation (0.6.6)
+ continuosDownload (91)
+ ejml (35313)
+ geotools (35169)
+ jaxb (35092)
+ jts (35122)
+ merge-overlap (35583)
+ o5m (35248)
+ opendata (35513)
+ pbf (35605)
+ poly (35248)
+ reverter (35579)
+ undelete (35521)
+ utilsplugin2 (35597)

Attachments (2)

cs-manager.PNG (62.9 KB ) - added by GerdP 3 years ago.
incompatible.patch (14.9 KB ) - added by GerdP 3 years ago.
don't commit

Download all attachments as: .zip

Change History (11)

by GerdP, 3 years ago

Attachment: cs-manager.PNG added

comment:1 by GerdP, 3 years ago

Description: modified (diff)

comment:2 by skyper, 3 years ago

In fact, this is #18985 (again?).

comment:3 by GerdP, 3 years ago

No, the sorting in changeset content panel still works.

comment:4 by skyper, 3 years ago

Oh, I sorry, mixed it up.

by GerdP, 3 years ago

Attachment: incompatible.patch added

don't commit

comment:5 by GerdP, 3 years ago

Cc: Don-vip added

Attached patch fixes the problem but it is completely incompatible with the unit test ChangesetCacheManagerTest. I am not sure what to do here. The existing test doesn't find problems like in this ticket, it just calls constructors with fake arguments.

comment:6 by GerdP, 3 years ago

Owner: changed from team to GerdP
Status: newneedinfo
Summary: Changeset manager shows wrong data after sorting[RFC] [Patch] Changeset manager shows wrong data after sorting

comment:7 by GerdP, 3 years ago

Owner: changed from GerdP to team
Status: needinfonew

comment:8 by gaben, 2 years ago

Noticed this issue some time ago, a bit annoying.

comment:9 by Don-vip, 2 years ago

Resolution: duplicate
Status: newclosed

Closed as duplicate of #21655.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.